-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nextjs session utils #767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Dec 18, 2023
rishabhpoddar
suggested changes
Dec 21, 2023
rishabhpoddar
suggested changes
Dec 21, 2023
rishabhpoddar
suggested changes
Dec 21, 2023
rishabhpoddar
suggested changes
Dec 21, 2023
rishabhpoddar
suggested changes
Dec 21, 2023
rishabhpoddar
approved these changes
Dec 21, 2023
rishabhpoddar
suggested changes
Dec 21, 2023
Also, fix all the PR checks. They are failing + resolve PR conflicts |
8a354f6
to
daddd0e
Compare
rishabhpoddar
suggested changes
Dec 22, 2023
5 tasks
rishabhpoddar
suggested changes
Dec 22, 2023
rishabhpoddar
suggested changes
Dec 25, 2023
rishabhpoddar
suggested changes
Dec 27, 2023
rishabhpoddar
suggested changes
Jan 2, 2024
rishabhpoddar
suggested changes
Jan 2, 2024
rishabhpoddar
suggested changes
Jan 3, 2024
rishabhpoddar
suggested changes
Jan 3, 2024
rishabhpoddar
suggested changes
Jan 3, 2024
rishabhpoddar
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds Next.js session util functions to be used with app dir. These changes will help us update Next.js code snippets for app dir throughout our docs.
Test Plan
Manually tested, that these utils work. Adding automated tests will require us to update Next.js version and that require us upgrading other packages including typescript.
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
recipe/thirdparty/providers/configUtils.ts
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.add-ts-no-check.js
file to include thatsomeFunc: function () {..}
).