error handling cleanup and general cleanup

supertokens · Feb 13, 2025 · 1c350be · 1c350be
1 parent 873df1e
commit 1c350be
Show file tree

Hide file tree

Showing 9 changed files with 568 additions and 797 deletions.
diff --git a/lib/build/recipe/webauthn/api/implementation.js b/lib/build/recipe/webauthn/api/implementation.js
@@ -52,6 +52,7 @@ function getAPIImplementation() {
             const supportedAlgorithmIds = constants_1.DEFAULT_REGISTER_OPTIONS_SUPPORTED_ALGORITHM_IDS;
             let response = await options.recipeImplementation.registerOptions(
                 Object.assign(Object.assign({}, props), {
+                    displayName: "displayName" in props ? props.displayName : undefined,
                     attestation,
                     residentKey,
                     userVerification,
@@ -304,7 +305,7 @@ function getAPIImplementation() {
                 userContext,
             });
             if (verifyResult.status !== "OK") {
-                return verifyResult;
+                return { status: "INVALID_CREDENTIALS_ERROR" };
             }
             const generatedOptions = await options.recipeImplementation.getGeneratedOptions({
                 webauthnGeneratedOptionsId,
@@ -855,8 +856,8 @@ function getAPIImplementation() {
                     });
                     if (
                         createUserResponse.status === "INVALID_CREDENTIALS_ERROR" ||
-                        createUserResponse.status === "GENERATED_OPTIONS_NOT_FOUND_ERROR" ||
-                        createUserResponse.status === "INVALID_GENERATED_OPTIONS_ERROR" ||
+                        createUserResponse.status === "OPTIONS_NOT_FOUND_ERROR" ||
+                        createUserResponse.status === "INVALID_OPTIONS_ERROR" ||
                         createUserResponse.status === "INVALID_AUTHENTICATOR_ERROR"
                     ) {
                         return createUserResponse;