Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue 534): replace reduce + spread operator with performant variant #538

Merged
merged 6 commits into from
Jun 2, 2024
Merged

fix(issue 534): replace reduce + spread operator with performant variant #538

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2d0666
feat: Add combineResultListFast utility function
flowreaction May 23, 2024
32e6ce8
feat: Add benchmark script for performance testing
flowreaction May 23, 2024
0d6d7e0
feat: Refactor combineResultList function for better performance
flowreaction May 24, 2024
16b7aba
feat: Optimize combineResultList function for better performance
flowreaction Jun 1, 2024
b0830f7
remove benchmark file
flowreaction Jun 1, 2024
2a34a15
remove commented unused function
flowreaction Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 28 additions & 24 deletions src/_internals/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,23 +27,24 @@ export type InferErrTypes<R> = R extends Result<unknown, infer E> ? E : never
export type InferAsyncOkTypes<R> = R extends ResultAsync<infer T, unknown> ? T : never
export type InferAsyncErrTypes<R> = R extends ResultAsync<unknown, infer E> ? E : never

const appendValueToEndOfList = <T>(value: T) => (list: T[]): T[] => [...list, value]

/**
* Short circuits on the FIRST Err value that we find
*/
export const combineResultList = <T, E>(
resultList: readonly Result<T, E>[],
): Result<readonly T[], E> =>
resultList.reduce(
(acc, result) =>
acc.isOk()
? result.isErr()
? err(result.error)
: acc.map(appendValueToEndOfList(result.value))
: acc,
ok([]) as Result<T[], E>,
)
): Result<readonly T[], E> => {
let acc = ok([]) as Result<T[], E>

for (const result of resultList) {
if (result.isErr()) {
acc = err(result.error)
break
} else {
acc.map((list) => list.push(result.value))
}
}
return acc
}

/* This is the typesafe version of Promise.all
*
Expand All @@ -62,18 +63,21 @@ export const combineResultAsyncList = <T, E>(
*/
export const combineResultListWithAllErrors = <T, E>(
resultList: readonly Result<T, E>[],
): Result<readonly T[], E[]> =>
resultList.reduce(
(acc, result) =>
result.isErr()
? acc.isErr()
? err([...acc.error, result.error])
: err([result.error])
: acc.isErr()
? acc
: ok([...acc.value, result.value]),
ok([]) as Result<T[], E[]>,
)
): Result<readonly T[], E[]> => {
let acc = ok([]) as Result<T[], E[]>

for (const result of resultList) {
if (result.isErr() && acc.isErr()) {
acc.error.push(result.error)
} else if (result.isErr() && acc.isOk()) {
acc = err([result.error])
} else if (result.isOk() && acc.isOk()) {
acc.value.push(result.value)
}
// do nothing when result.isOk() && acc.isErr()
}
return acc
}

export const combineResultAsyncListWithAllErrors = <T, E>(
asyncResultList: readonly ResultAsync<T, E>[],
Expand Down