Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Goldens - Option 2 #2184

Merged

Conversation

CillianMyles
Copy link
Member

@CillianMyles CillianMyles commented Jul 24, 2024

This PR fixes the goldens by:

  • Regenerating them (without any code changes) from the golden tests docker image

@matthew-carroll
Copy link
Contributor

@CillianMyles can you let me know what the takeaway is from this PR? I don't see a description of any problems that you found or resolved - also, the goldens still fail...

@CillianMyles
Copy link
Member Author

@CillianMyles can you let me know what the takeaway is from this PR? I don't see a description of any problems that you found or resolved - also, the goldens still fail...

Apologies this one should have been removed. I assumed it would have fixed the tests by regenerating the goldens. I used a Linux/Ubuntu machine because I saw ubuntu-latest mentioned the GitHub actions job for the PR checks, and regenerating them on Mac failed in my PR. I did not see anything in the docs about this, or docker. I will look for info about docker and resolve the other PR.

@matthew-carroll
Copy link
Contributor

@CillianMyles here's the README on tests, including goldens: https://github.com/superlistapp/super_editor/blob/main/super_editor/README_TESTS.md

@matthew-carroll
Copy link
Contributor

@CillianMyles given that this PR gets the tests passing without altering any source code, is there any reason that we should be considering the other PR? #2183

@CillianMyles
Copy link
Member Author

@CillianMyles given that this PR gets the tests passing without altering any source code, is there any reason that we should be considering the other PR? #2183

If you're happier with this one then let's drop the other one.

It's better not to change things on a whim, that are not needed, and that we don't necessarily understand the original intention behind (mixing of Android and iOS configs).

Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit bce163a into superlistapp:main Jul 27, 2024
21 checks passed
@matthew-carroll
Copy link
Contributor

@angelosilvestre can you cherry pick this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants