-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Goldens - Option 2 #2184
Fix Goldens - Option 2 #2184
Conversation
@CillianMyles can you let me know what the takeaway is from this PR? I don't see a description of any problems that you found or resolved - also, the goldens still fail... |
Apologies this one should have been removed. I assumed it would have fixed the tests by regenerating the goldens. I used a Linux/Ubuntu machine because I saw |
@CillianMyles here's the README on tests, including goldens: https://github.com/superlistapp/super_editor/blob/main/super_editor/README_TESTS.md |
@CillianMyles given that this PR gets the tests passing without altering any source code, is there any reason that we should be considering the other PR? #2183 |
If you're happier with this one then let's drop the other one. It's better not to change things on a whim, that are not needed, and that we don't necessarily understand the original intention behind (mixing of Android and iOS configs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@angelosilvestre can you cherry pick this? |
This PR fixes the goldens by: