SUP-5912: Payment Helper post-bencharking #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramarun
requested review from
sujithsomraaj and
0xTimepunk
and removed request for
sujithsomraaj
sujithsomraaj
suggested changes
Jan 17, 2024
fix: SUP-5192 PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address low payment helper estimates not appropriately estimating costs on the destination chain by adjusting logic in
_estimateDstExecutionCostNote: requires config setting of
ackGasCost[CHAIN_ID]to reflect lower gas price to process acknowledgement and theackGasCost[other chains]to be very high to reflect cost to move message from dst to srcTODO: Update deployment script for new config numbers before merging:
updateGasUsedArb = 1M, others = 200kackGasCost[CHAIN_ID], Arb = 500k, others = 150k -- i.e. ackGasCost on 42161 of ackGasCost[42161] = 500kswapGasUsedArb = 2M, others = 1M