Merge pull request #422 from superform-xyz/SUP-5019

chore: fix indexed keyword issue in events
superform-xyz · Jan 15, 2024 · 6dd881e · 6dd881e
2 parents 684ef82 + f6c0398
commit 6dd881e
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/src/crosschain-data/BaseStateRegistry.sol b/src/crosschain-data/BaseStateRegistry.sol
@@ -16,7 +16,6 @@ import { PayloadState, AMBMessage, AMBExtraData } from "src/types/DataTypes.sol"
 /// mechanisms.
 /// @author Zeropoint Labs
 abstract contract BaseStateRegistry is IBaseStateRegistry {
-
     using ProofLib for AMBMessage;
     using ProofLib for bytes;
 
@@ -117,7 +116,7 @@ abstract contract BaseStateRegistry is IBaseStateRegistry {
             bytes32 proofHash = abi.decode(data.params, (bytes32));
             ++messageQuorum[proofHash];
 
-            emit ProofReceived(data.params);
+            emit ProofReceived(proofHash);
         } else {
             /// @dev if message, store header and body of it
             ++payloadsCount;

diff --git a/src/crosschain-data/adapters/layerzero/LayerzeroImplementation.sol b/src/crosschain-data/adapters/layerzero/LayerzeroImplementation.sol
@@ -16,7 +16,6 @@ import { ILayerZeroUserApplicationConfig } from "src/vendor/layerzero/ILayerZero
 /// @dev Allows state registries to use Layerzero for crosschain communication
 /// @author Zeropoint Labs
 contract LayerzeroImplementation is IAmbImplementation, ILayerZeroUserApplicationConfig, ILayerZeroReceiver {
-
     using DataLib for uint256;
 
     //////////////////////////////////////////////////////////////
@@ -41,8 +40,8 @@ contract LayerzeroImplementation is IAmbImplementation, ILayerZeroUserApplicatio
     //////////////////////////////////////////////////////////////
 
     event EndpointUpdated(address indexed oldEndpoint_, address indexed newEndpoint_);
-    event MessageFailed(uint16 indexed srcChainId_, bytes indexed srcAddress_, uint64 indexed nonce_, bytes payload_);
-    event SetTrustedRemote(uint16 indexed srcChainId_, bytes indexed srcAddress_);
+    event MessageFailed(uint16 indexed srcChainId_, bytes srcAddress_, uint64 indexed nonce_, bytes payload_);
+    event SetTrustedRemote(uint16 indexed srcChainId_, bytes srcAddress_);
 
     //////////////////////////////////////////////////////////////
     //                       MODIFIERS                          //

diff --git a/src/interfaces/IBaseStateRegistry.sol b/src/interfaces/IBaseStateRegistry.sol
@@ -16,7 +16,7 @@ interface IBaseStateRegistry {
 
     /// @dev is emitted when a cross-chain proof is received in the state registry
     /// NOTE: comes handy if quorum required is more than 0
-    event ProofReceived(bytes indexed proof);
+    event ProofReceived(bytes32 indexed proof);
 
     /// @dev is emitted when a payload id gets updated
     event PayloadUpdated(uint256 indexed payloadId);

diff --git a/src/interfaces/ICoreStateRegistry.sol b/src/interfaces/ICoreStateRegistry.sol
@@ -35,8 +35,8 @@ interface ICoreStateRegistry {
     /// @dev is emitted when a rescue is proposed for failed deposits in a payload
     event RescueProposed(
         uint256 indexed payloadId,
-        uint256[] indexed superformIds,
-        uint256[] indexed proposedAmount,
+        uint256[] superformIds,
+        uint256[] proposedAmount,
         uint256 proposedTime
     );
 

diff --git a/src/interfaces/IPaymentHelper.sol b/src/interfaces/IPaymentHelper.sol
@@ -14,7 +14,6 @@ import {
 /// @dev Interface for PaymentHelper
 /// @author ZeroPoint Labs
 interface IPaymentHelper {
-
     //////////////////////////////////////////////////////////////
     //                           STRUCTS                         //
     //////////////////////////////////////////////////////////////
@@ -50,7 +49,7 @@ interface IPaymentHelper {
     //                          EVENTS                          //
     //////////////////////////////////////////////////////////////
 
-    event ChainConfigUpdated(uint64 indexed chainId_, uint256 indexed configType_, bytes indexed config_);
+    event ChainConfigUpdated(uint64 indexed chainId_, uint256 indexed configType_, bytes config_);
     event ChainConfigAdded(uint64 chainId_, PaymentHelperConfig config_);
 
     //////////////////////////////////////////////////////////////