Skip to content

Commit

Permalink
Merge pull request #470 from superform-xyz/v1
Browse files Browse the repository at this point in the history
fix: remove view keyword
  • Loading branch information
0xTimepunk authored Feb 15, 2024
2 parents b890e76 + d783ca5 commit 601ab0d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 19 deletions.
12 changes: 2 additions & 10 deletions script/Abstract.Deploy.Single.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ abstract contract AbstractDeploySingle is Script {
bytes32 emergencyAdminRole = srbac.EMERGENCY_ADMIN_ROLE();

if (grantProtocolAdmin) srbac.grantRole(protocolAdminRole, PROTOCOL_ADMINS[trueIndex]);

srbac.grantRole(emergencyAdminRole, EMERGENCY_ADMIN);

//srbac.revokeRole(emergencyAdminRole, ownerAddress);
Expand Down Expand Up @@ -1171,15 +1171,7 @@ abstract contract AbstractDeploySingle is Script {
}
}

function _readContract(
string memory name,
uint64 chainId,
string memory contractName
)
internal
view
returns (address)
{
function _readContract(string memory name, uint64 chainId, string memory contractName) internal returns (address) {
string memory json;
string memory root = vm.projectRoot();
json =
Expand Down
10 changes: 1 addition & 9 deletions test/utils/MainnetBaseSetup.sol
Original file line number Diff line number Diff line change
Expand Up @@ -536,15 +536,7 @@ abstract contract MainnetBaseSetup is DSTest, StdInvariant, Test {
priceFeeds[GNOSIS][ARBI] = 0xa767f745331D267c7751297D982b050c93985627;
}

function _readContract(
string memory name,
uint64 chainId,
string memory contractName
)
internal
view
returns (address)
{
function _readContract(string memory name, uint64 chainId, string memory contractName) internal returns (address) {
string memory json;
string memory root = vm.projectRoot();
json = string(abi.encodePacked(root, folderToRead, vm.toString(uint256(chainId)), "/", name, "-latest.json"));
Expand Down

0 comments on commit 601ab0d

Please sign in to comment.