Skip to content

Commit

Permalink
type fix (#1771)
Browse files Browse the repository at this point in the history
  • Loading branch information
0xdavinchee authored Jan 4, 2024
1 parent 5f66bbb commit 1bf8e7c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/sdk-core/src/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -436,5 +436,6 @@ export interface BondIncreasedEvent extends EventBase {
}

export interface UnknownEvent extends EventBase {
name: string;
// @note using the string type breaks the type guard
name: "";
}
3 changes: 2 additions & 1 deletion packages/sdk-core/src/mapGetAllEventsQueryEvents.ts
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,8 @@ export const mapGetAllEventsQueryEvents = (
`An unknown event [${eventBase.name}] was detected which couldn't be properly mapped. Please update to the latest version of @superfluid-finance/sdk-core.`
);
return typeGuard<events.UnknownEvent>({
name: eventBase.name,
// force casted as empty string for the type system
name: eventBase.name as "",
id: eventBase.id,
blockNumber: eventBase.blockNumber,
transactionHash: eventBase.transactionHash,
Expand Down

0 comments on commit 1bf8e7c

Please sign in to comment.