Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history out of sync in time travel mode #15

Merged
merged 3 commits into from
Dec 28, 2016

Conversation

supasate
Copy link
Owner

Fix #8

@supasate supasate merged commit 7edb44e into master Dec 28, 2016
@supasate supasate deleted the fix-history-out-of-sync-in-time-travelling branch December 28, 2016 10:14
@zalmoxisus
Copy link

This looks great! You might not want to do an additional check and traversing context.store.getState().router.location.pathname when not using Redux DevTools. I was thinking to add such functionality right in Redux DevTools, but didn't figure out a reasonable API implementation, since we we want to call only specific middlewares, store enhancers or simple functions.

@supasate
Copy link
Owner Author

Hi @zalmoxisus, great to see you here. Your DevTools extension is awesome!
It would be great if there is such API right in Redux DevTools. Something like .isAtLastState() or .isReplaying() would be nice.

@zalmoxisus
Copy link

@supasate, thanks for the kind words. We've introduced such an API in 2.3.0, but added a deprecation warning in the latest. It wouldn't be easy for users to use such API.

IMO, there are 2 options:

  1. To pass the middleware function to the extension like here.
  2. To have our applyMiddleware as we do with compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants