fix: stop using unstable type params from postgrest-js #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7382975635
💛 - Coveralls |
soedirgo
force-pushed
the
feat/bump-postgrest-js
branch
from
bff727c to
586b6a9
Compare
soedirgo
added a commit
that referenced
this pull request
Feb 19, 2024
Reverts #935. It's no longer needed because we now pin the specific postgrest-js version, so the out-of-sync issue mentioned in the PR can be avoided.
kamilogorek
pushed a commit
that referenced
this pull request
Feb 19, 2024
Reverts #935. It's no longer needed because we now pin the specific postgrest-js version, so the out-of-sync issue mentioned in the PR can be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently duplicating passing the type params to postgrest-js classes - we may change the order and/or add new type params on the postgrest-js side, so the type params in supabase-js can get out of sync.
This also fixes the issue in this demo (
usersindatashould beT[], notT | null).