Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passover #13

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Passover #13

merged 9 commits into from
Mar 1, 2024

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Feb 28, 2024 •
edited
Loading

Fixes #11
Fixes #12
Fixes #10
Fixes #9
Fixes #8
Fixes #7

So the only breaking change is the removal of the GONG Map Class.
Everything else should be untouched.

TODO:

  • Check conversion of tex file to rst is ok
  • Check each example is running expect the ones with helpers in the name.

@Cadair
Copy link
Member

Cadair commented Feb 28, 2024

You broke the CI 😝

@nabobalis
Copy link
Contributor Author

There is a real failure I am trying to track down.

Cadair
Cadair reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not do this kind of cleanup with the templated files if we ever want the auto-updater to work. We need to work really hard to minimise the number of changes we make to files we template.

README.rst Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/manual/source/numerical-methods.blg Outdated Show resolved Hide resolved
docs/manual/source/numerical-methods.tex Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
sunkit_magex/__init__.py Show resolved Hide resolved
sunkit_magex/pfss/tests/test_fieldline.py Outdated Show resolved Hide resolved
sunkit_magex/pfss/utils.py Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@nabobalis
Copy link
Contributor Author

We can not do this kind of cleanup with the templated files if we ever want the auto-updater to work. We need to work really hard to minimise the number of changes we make to files we template.

Then you should fix the template.

@nabobalis nabobalis force-pushed the docs branch 2 times, most recently from f114b79 to 16e10af Compare February 28, 2024 19:17
@nabobalis nabobalis marked this pull request as ready for review February 28, 2024 19:17
@nabobalis
Copy link
Contributor Author

It is missing a changelog system. Do we want to fix that?

Cadair
Cadair requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting changes which don't fix anything need to be made in the template. Easiest thing to do would be to pull them here and re-add them later as part of retemplating.

@Cadair
Copy link
Member

Cadair commented Feb 28, 2024

It is missing a changelog system. Do we want to fix that?

If we need it now then yes, otherwise we could wait for it to land in the template.

@nabobalis nabobalis force-pushed the docs branch 4 times, most recently from e926d92 to 97cd96f Compare February 28, 2024 20:36
@nabobalis
Copy link
Contributor Author

RTD is missing?

@nabobalis nabobalis force-pushed the docs branch 5 times, most recently from 5b5b60b to 3ce6410 Compare February 29, 2024 05:49
@Cadair
Copy link
Member

Cadair commented Feb 29, 2024

RTD is missing?

I hadn't clicked the "build pull requests button"

@Cadair
Copy link
Member

Cadair commented Feb 29, 2024 •
edited
Loading

I pulled all the changes from this that I moved to the template here: sunpy/package-template#59 Once that's merged I can update this PR with those changes.

I wanted to do it before the baby wakes up so I merged it.

@nabobalis nabobalis force-pushed the docs branch 2 times, most recently from 9ccb977 to b90d015 Compare February 29, 2024 14:36
@nabobalis nabobalis force-pushed the docs branch 5 times, most recently from 407cedd to 11f5cc1 Compare February 29, 2024 16:49
nabobalis
nabobalis commented Feb 29, 2024
View reviewed changes
sunkit_magex/pfss/__init__.py
from .input import Input
from .output import Output
from .pfss import pfss
__all__ = ['coords', 'fieldline', 'sample_data', 'tracing', 'utils', 'Input', 'Output', 'pfss']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the same namespace but its now explicit.

nabobalis
nabobalis commented Feb 29, 2024
View reviewed changes
docs/conf.py Outdated Show resolved Hide resolved
@nabobalis nabobalis force-pushed the docs branch 2 times, most recently from 7e2db04 to e5f2b7e Compare February 29, 2024 17:17
nabobalis
nabobalis commented Feb 29, 2024
View reviewed changes
docs/conf.py Outdated Show resolved Hide resolved
@nabobalis nabobalis requested a review from Cadair February 29, 2024 18:34
Cadair
Cadair requested changes Feb 29, 2024
View reviewed changes
.ruff.toml Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
sunkit_magex/data/README.rst Show resolved Hide resolved
sunkit_magex/tests/__init__.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Cadair
Cadair reviewed Mar 1, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Cadair
Cadair requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci? cWHYYY?

@Cadair Cadair merged commit 91f8297 into main Mar 1, 2024
10 of 12 checks passed
@Cadair Cadair deleted the docs branch March 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nabobalis @Cadair