add workflow for updating duckdb refs #24
Conversation
srikrishnak
force-pushed
the
sd9320
branch
2 times, most recently
from
ba8f83d to
3ce62b6
Compare
srikrishnak
force-pushed
the
sd9320
branch
18 times, most recently
from
86f372e to
88ae2b3
Compare
srikrishnak
force-pushed
the
sd9320
branch
7 times, most recently
from
4a9e502 to
7a244ee
Compare
srikrishnak
force-pushed
the
sd9320
branch
2 times, most recently
from
d2344d3 to
cc86b7b
Compare
srikrishnak
force-pushed
the
sd9320
branch
9 times, most recently
from
e102286 to
e744686
Compare
srikrishnak
changed the title
| echo "COMMIT_DETAILS=$COMMIT_DETAILS" >> "$GITHUB_ENV" | ||
| - name: Commit and Push Updates | ||
| uses: stefanzweifel/git-auto-commit-action@v5 | ||
| with: |
There was a problem hiding this comment.
@rymurr I couldn't test this step as it doesn't find the branch sd9320 on sundeck.io/duckdb-go-extensions. Wondering if it is ok to create a branch.
Or I could test this once it merges to main
There was a problem hiding this comment.
I checked the diff as well, only part I didn't check is the final commit that gets raised.
I put a workflow_dispatch so i can trigger and see how the commit looks like once this is merged.
There was a problem hiding this comment.
I think this is goign to commit to main if run on main, I think rather than commit you want to create a PR
| echo "COMMIT_DETAILS=$COMMIT_DETAILS" >> "$GITHUB_ENV" | ||
| - name: Commit and Push Updates | ||
| uses: stefanzweifel/git-auto-commit-action@v5 | ||
| with: |
There was a problem hiding this comment.
I think this is goign to commit to main if run on main, I think rather than commit you want to create a PR
| shell: bash | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | |
There was a problem hiding this comment.
I think it would be good to skip the update if the duckdb ref hasn't updated. I don't think we want to update the extensions if we aren't updating dudckdb
There was a problem hiding this comment.
Agree that is better approach as it saves cycles but just to confirm, I think we might lose one corner case.
- lets sayd duckdb updated to a latest release A, and we found a stable build with all extensions and merged the commit.
- later, in one of the extensions, like substrait, we did a commit B on the same release A.
We might miss a chance to pull that commit B. @rymurr Thoughts?
No description provided.