more

sunchao · Feb 13, 2024 · c3fe4a3 · c3fe4a3
1 parent 4ad923c
commit c3fe4a3
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -66,16 +66,19 @@ jobs:
           cd core
           cargo check --benches
 
+      - name: Setup JAVA_HOME
+        run: |
+          echo "JAVA_HOME=/usr/lib/jvm/java-${{env.JAVA_VERSION}}-openjdk-amd64" >> $GITHUB_ENV
+
       - name: Build common module (pre-requisite for Rust tests)
-        env:
-          JAVA_HOME: /usr/lib/jvm/java-${{env.JAVA_VERSION}}-openjdk-amd64
         run: |
-          echo "LIBRARY_PATH=$JAVA_HOME/lib:$JAVA_HOME/lib/server:$LD_LIBRARY_PATH" >> $GITHUB_ENV
           cd common
           ../mvnw clean compile -DskipTests
 
       - name: Run cargo test
         run: |
+          # This is required to run some JNI related tests on the Rust side
+          echo "LIBRARY_PATH=$JAVA_HOME/lib:$JAVA_HOME/lib/server:$LD_LIBRARY_PATH" >> $GITHUB_ENV
           cd core
           cargo test --release
 
@@ -97,9 +100,13 @@ jobs:
           cd core
           cargo build
 
+      - name: Setup JAVA_HOME
+        run: |
+          echo "JAVA_HOME=/usr/lib/jvm/java-${{env.JAVA_VERSION}}-openjdk-amd64" >> $GITHUB_ENV
+
       - name: Run Maven compile
         run: |
-          ./mvnw compile test-compile scalafix:scalafix -Psemanticdb -Dscalafix.mode=Check
+          ./mvnw compile test-compile scalafix:scalafix -Psemanticdb
 
       - name: Run Maven install
         run: |