Skip to content

Commit

Permalink
minor: Only trigger PR title checker on pull requests
Browse files Browse the repository at this point in the history
  • Loading branch information
sunchao committed Mar 3, 2024
1 parent a3dd8df commit bdf3363
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 15 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/pr_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,18 +188,3 @@ jobs:
with:
MAVEN_OPTS: -Pspark-${{ matrix.spark-version }}

check-pr-title:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check PR title
env:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
if ! echo $PR_TITLE | grep -Eq '^(\w+)(\(.+\))?: .+$'; then
echo "PR title does not follow conventional commit style."
echo "Please use a title in the format: type: message, or type(scope): message"
echo "Example: feat: Add support for sort-merge join"
exit 1
fi
43 changes: 43 additions & 0 deletions .github/workflows/pr_title_check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

name: Check PR Title

concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
cancel-in-progress: true

on:
pull_request:
types: [opened, edited, reopened]

jobs:
check-pr-title:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check PR title
env:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
if ! echo $PR_TITLE | grep -Eq '^(\w+)(\(.+\))?: .+$'; then
echo "PR title does not follow conventional commit style."
echo "Please use a title in the format: type: message, or type(scope): message"
echo "Example: feat: Add support for sort-merge join"
exit 1
fi

0 comments on commit bdf3363

Please sign in to comment.