Fixed bug in optika.rulings where the amplitude of the grating wasn…

…'t being accounted for correctly.
sun-data · Mar 25, 2024 · 2711170 · 2711170
1 parent b7a891e
commit 2711170
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/optika/rulings/_rulings.py b/optika/rulings/_rulings.py
@@ -411,7 +411,8 @@ def efficiency(
 
         wavelength = rays.wavelength
         cos_theta = -direction @ normal
-        d = self.depth
+        amplitude = np.pi / 4
+        d = self.depth / amplitude
         i = self.diffraction_order
 
         gamma = np.pi * d / (wavelength * cos_theta)
@@ -555,7 +556,8 @@ def efficiency(
 
         wavelength = rays.wavelength
         cos_theta = -direction @ normal
-        d = self.depth
+        amplitude = np.pi / 2
+        d = self.depth / amplitude
         i = self.diffraction_order
 
         gamma = np.pi * d / (wavelength * cos_theta)
@@ -693,7 +695,8 @@ def efficiency(
 
         wavelength = rays.wavelength
         cos_theta = -direction @ normal
-        d = self.depth
+        amplitude = np.square(np.pi) / 8
+        d = self.depth / amplitude
         i = self.diffraction_order
 
         gamma = np.pi * d / (wavelength * cos_theta)
@@ -843,8 +846,9 @@ def efficiency(
 
         wavelength = rays.wavelength
         cos_theta = -direction @ normal
-        d = self.depth
         a = 2 * np.pi * self.ratio_duty
+        amplitude = np.pi / (2 * np.sqrt(2 * (1 - np.cos(a))))
+        d = self.depth / amplitude
         i = self.diffraction_order
 
         gamma = np.pi * d / (wavelength * cos_theta)