Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust webspace naming #826

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

Prokyonn
Copy link
Member

@Prokyonn Prokyonn commented Dec 11, 2024

Q A
Fixed tickets fixes #issuenum
Related PRs sulu/sulu#prnum
License MIT

What's in this PR?

In the new Sulu Skeleton the webspace name was changes from example to website.

@@ -270,7 +270,7 @@ localization. The following fragment shows again how to this:

.. code-block:: xml

<url language="de" country="at">www.example.org</url>
<url language="de" country="at">www.website.org</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would still use example.org in the official examples as it is official domain special for this kind of things :)

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should in example configuration still the example.org domain:

website.com, website.org -> example.org

As that is official standard Domain for examples and can not be Hijacking by somebody in the future.

@alexander-schranz alexander-schranz merged commit fe84eb3 into sulu:2.6 Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants