Add List filter configuration #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
list-filter
branch
2 times, most recently
from
e6c015b to
0471120
Compare
alexander-schranz
requested changes
Oct 25, 2022
wachterjohannes
force-pushed
the
list-filter
branch
2 times, most recently
from
dec79ab to
4218cb1
Compare
|
@alexander-schranz fixed |
wachterjohannes
force-pushed
the
list-filter
branch
from
4218cb1 to
51a709f
Compare
2 tasks
wachterjohannes
force-pushed
the
list-filter
branch
from
51a709f to
d02acff
Compare
Controller/ArticleController.php
Outdated
| * pageId?: string, | ||
| * publishedState?: string, | ||
| * } $filter */ | ||
| $filter = $request->get('filter'); |
There was a problem hiding this comment.
Suggested change
| $filter = $request->get('filter'); | |
| $filter = $request->query->get('filter'); |
There was a problem hiding this comment.
$request->query->get('filter') cannot return an array 🙈
There was a problem hiding this comment.
$request->query->all('filter')There was a problem hiding this comment.
looks like does not exist on 4.4 so:
$request->query->all()['filter'] ?? []that is similar to the request get
wachterjohannes
force-pushed
the
list-filter
branch
from
d02acff to
a9f318d
Compare
|
@alexander-schranz fixed |
|
Should we target this as a new feature (2.5 not released yet) or as a bugfix (2.4)? /cc @chirimoya |
|
@alexander-schranz is a bugfix for me 😂 |
alexander-schranz
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR add the filter configuration for article-lists.