Adding Web of Science harvest #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
force-pushed
the
wos-harvest
branch
7 times, most recently
from
1062202 to
becde5b
Compare
edsu
force-pushed
the
wos-harvest
branch
6 times, most recently
from
b3b97ca to
3620115
Compare
edsu
commented
Mar 5, 2025
| @@ -28,7 +28,8 @@ dependencies = [ | |||
| [tool.pytest.ini_options] | |||
| pythonpath = ["."] | |||
| markers = "mais_tests: Tests requiring MAIS access" | |||
| addopts = "-v --cov --cov-report=html --cov-report=term" | |||
| addopts = "-v --cov --cov-report=html --cov-report=term --log-level INFO --log-file test.log" | |||
There was a problem hiding this comment.
It was useful for me to see the log messages. But I can remove if this is noisy.
edsu
commented
Mar 5, 2025
| @@ -150,6 +159,9 @@ def publish(pubs_to_contribs, merge_publications): | |||
|
|
|||
| openalex_jsonl = openalex_harvest(snapshot) | |||
|
|
|||
There was a problem hiding this comment.
Eventually we'll want to tie the WoS harvesting into the workflow, but for now nothing is dependent on it.
lwrubel
reviewed
Mar 6, 2025
lwrubel
reviewed
Mar 6, 2025
|
|
||
|
|
||
| def check_status(resp): | ||
| # see https://github.com/sul-dlss/rialto-airflow/issues/208 |
There was a problem hiding this comment.
thanks for the links to these issues
lwrubel
reviewed
Mar 6, 2025
lwrubel
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a harvester for Web of Science publications by ORCID. I've tested with
AIRFLOW_VAR_DEV_LIMIT=50000which helped discover some unexpected responses from the WoS API that I needed to handle see #207 and #208.The API call was determined by looking at sul_pub's querying by ORCID and how the API KEY is passed.
Closes #165