[HOLD] 0014-cocina-model-tweaks commit #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
force-pushed
the
0014-cocina-model-tweaks
branch
from
5934926 to
314700a
Compare
mjgiarlo
reviewed
Mar 2, 2022
| @@ -0,0 +1,367 @@ | |||
| --- | |||
| layout: default | |||
| title: ADR-0014 | |||
mjgiarlo
reviewed
Mar 2, 2022
| exclude_rule "MD013" | ||
| exclude_rule 'MD013' | ||
| # Allow headers to have the same content if they have different parents | ||
| rule 'MD024', allow_different_nesting: true |
There was a problem hiding this comment.
I generally find MarkdownLint's rules reasonable, but I added this configuration to allow for repeated subheaders (across headers), e.g., Cost and Value in this PR.
jcoyne
approved these changes
Mar 2, 2022
|
@sul-dlss-labs/infrastructure-team Should we merge and then discuss? Or use the PR for comments and suggestions? |
mjgiarlo
changed the title
|
@ndushay Do we want to keep this hanging around? Or revisit it? Or ditch it? etc. |
|
@mjgiarlo i no longer care. whatevs. |
|
I think this was a place to put "things we might want to change in cocina" after we did a bunch of changes in the "get off fedora" days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ADR 0014 which describes a number of proposed cocina model tweaks.