Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done the Enhanced CSS Styling of NewsShelter Section #625 #629

Closed
wants to merge 1 commit into from

Conversation

Pranjal6955
Copy link

Description

This pull request introduces design enhancements to the NewsShelter section, focusing on the email input field and the subscribe button. These updates aim to deliver a more polished and user-friendly interface, aligned with modern design practices, while improving the overall user experience.


Changes Made

Email Input Field Enhancements

  • Added a rounded border for a softer and more appealing look.
  • Implemented a subtle glow effect on focus to enhance interactivity and draw user attention.
  • Included the required attribute for improved form validation.

Subscribe Button Enhancements

  • Applied a hover effect with a smooth color transition to provide visual feedback.
  • Adjusted padding for better alignment and visual harmony with the input field.

Scoped Styles

  • Scoped all new styles locally within <style> tags to ensure they do not interfere with global styles.

Screenshots

  1. Before Enhancements:
    IMG1

  2. After Enhancements:
    IMG2


Impact

Enhanced User Experience

  • A visually appealing and interactive interface that encourages user engagement.

Improved Accessibility

  • Refined designs ensure usability across various screen sizes and enhance responsiveness.

Better Maintainability

  • Scoped styles make the design changes easier to manage without affecting global CSS.

@Pranjal6955 Pranjal6955 changed the title Enhanced CSS Styling of NewsShelter Section #625 Done the Enhanced CSS Styling of NewsShelter Section #625 Jan 2, 2025
@Pranjal6955
Copy link
Author

@quozl Please Review my PR

@quozl
Copy link
Contributor

quozl commented Jan 2, 2025

@vidipsingh please review this pull request. 😁

@vidipsingh
Copy link
Contributor

Sure, @quozl, I’ll take a look at this PR.

  • @Pranjal6955, I noticed that you’ve added the CSS styling directly in the index.html file. Please move all the CSS classes to the css/ folder, as the entire site is structured to load styles from there. Avoid using internal CSS in the HTML files, as it can lead to clutter and inconsistency. Since all pages are pulling custom CSS classes from the css/ folder, it’s best to follow this approach for maintainability and consistency across the site.

  • Also, @Pranjal6955, please avoid making pull requests from your master branch. Always create a new branch for the specific issue you're working on, and then make your changes there. Please be mindful of this in the future.

  • Additionally, your commit message doesn’t clearly explain the changes you’ve made. For guidelines on how to write better commit messages, please refer to this document.

@Pranjal6955 Pranjal6955 closed this by deleting the head repository Jan 3, 2025
@quozl
Copy link
Contributor

quozl commented Jan 3, 2025

Forward link to new pull request; #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants