-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Info Page for Community Channels #616
base: master
Are you sure you want to change the base?
Conversation
@quozl this time I add all the files in a single commit as they all are added to to create a single page only so is it the correct way or any changes required |
looks very nice! |
Thanks @retrogtx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- our guide to making commit messages has not been followed,
- the screenshots do not scale,
- the screenshots do not follow browser dark and light mode preferences.
I'd be happy not to have screenshots.
</div> | ||
</div> | ||
</div> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline at end of file.
.join-mat:active { | ||
top:0.1em; | ||
color: #fff !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change css/airspace.css, as this will hinder our merge of upstream change. Change css/custom.css instead, or another css file.
counter.innerText = `${target}+`; | ||
} | ||
|
||
counter.innerText = target.toLocaleString() + '+'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have included changes relating to the counters pull request. Are you trying to sneak these past? 😁
My idea for screenshots were to help a newbie understand what to see when navigating creating an account for the first time. I don't think you should use those screenshots. This is more of what I was thinking of: In fact, that one screenshot is probably sufficient. We may want to also find an "official" how-to for registering to Matrix for the first time that we can link to, so that we know we're sending people to something that's probably always up-to-date, and that we don't have to maintain ourselves. |
@pikurasa okay so i ll be deleting the images and also trying to add more text information about the make account creation and also try to search some matrix link to their guide for creating an account for matrix and again similar for discord too. |
Creating Informative Page for the Community Channel
New page in website provides more understanding to the community channel for chat and discussion