Fix: Corrected MIDI pitch note addition bug #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterbender @pikurasa Pls review it |
walterbender
requested changes
Jan 2, 2025
js/widgets/musickeyboard.js
Outdated
| @@ -1917,7 +1917,8 @@ function MusicKeyboard(activity) { | |||
| this._createAddRowPieSubmenu = function () { | |||
| docById("wheelDivptm").style.display = ""; | |||
| // docById("wheelDivptm").style.zIndex = "300"; | |||
| const pitchLabels = ["do", "re", "mi", "fa", "sol", "la", "ti"]; | |||
| const pitchLabels = [ "do", "do♯", "re", "re♯", "mi", "fa", "fa♯", "sol", "sol♯", "la", "la♯", "ti", | |||
There was a problem hiding this comment.
Please remove spaces before "do" and put the ] on this line.
js/widgets/musickeyboard.js
Outdated
| @@ -2115,6 +2119,11 @@ function MusicKeyboard(activity) { | |||
| this.displayLayout = this.displayLayout.concat(sortedHertzList); | |||
| this._createKeyboard(); | |||
| this._createTable(); | |||
| const n= this.layout.length; | |||
js/widgets/musickeyboard.js
Outdated
| @@ -2115,6 +2119,11 @@ function MusicKeyboard(activity) { | |||
| this.displayLayout = this.displayLayout.concat(sortedHertzList); | |||
| this._createKeyboard(); | |||
| this._createTable(); | |||
| const n= this.layout.length; | |||
| const key = this.layout[n-1]; | |||
|
@walterbender I have made the required changes. Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix resolves an issue where newly added 'pitch' notes in the Music Keyboard Widget did not work with MIDI playback until the keyboard was restarted. While notes through virtual keyboard were clickable, they failed to play with MIDI initially.
Changes Made
1.Replaced the simpler pitchLabels array with a detailed version including sharps
2.Updated the logic to ensure new pitches don’t duplicate existing ones in the layout.
3.Ensured getElement mappings are updated immediately for new notes:
Testing
Verified that new pitches are functional immediately via MIDI without requiring a widget restart.
Untitled.video.-.Made.with.Clipchamp.mp4
Related Issue
Fixes #4149 - Bug in MIDI