Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for RhythmBlocksAPI and DrumBlocksAPI in /js/js-exports/API (#4200) #4208

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

BeNikk
Copy link
Contributor

@BeNikk BeNikk commented Dec 29, 2024

Summary of Changes

This pull request addresses issue #4200 by adding tests for the following files:

  • RhythmBlocksAPI: V
  • DrumBlocksAPI:
    Screenshot from 2024-12-30 00-15-15

@BeNikk
Copy link
Contributor Author

BeNikk commented Dec 29, 2024

I guess @justin212407 was working on other files in the API folder

@justin212407
Copy link
Contributor

@BeNikk yeah i will be making a pr on the same soon

@omsuneri
Copy link
Contributor

omsuneri commented Jan 3, 2025

@walterbender what is the issue with merging these tests as i had also prepared same tests should i raise a PR for the same

@walterbender walterbender merged commit f0ac406 into sugarlabs:master Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants