-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class to js/widgets/temperament.js and port ES6 to syntax. #2773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there already is an existing PR that ports this file to ES6 and handles bugs as well check #2772 |
So, should I work on this file further to resolve these issues or start working on a different one? |
The issues that I mentioned above, occurred because of the port you did. I suggest you take up testing the platform, dig for some bugs and if they exist, solve them like in #2771 and #2772. You can also solve some of the open issues with Suggestions while porting files:-
There are chances you'll miss something somewhere while creating PRs, no issues, we all do. Community members will help you out, Good luck. |
Thanks for the insight, @ricknjacky..... |
You're welcome :)
Most of the discussion is done on GitHub i.e. either on the issues tab or discussions tab of the repository and sometimes in certain PRs too. Please feel free to use them for your perusal. p.s:- You can close this PR. |
Please review @meganindya .