Fix TypeError due to Bool arguments in ElementTree #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed, thanks. Your commit message said
|
|
Thankyou for pointing that out, I have updated the commit message. |
|
Commit message does not indicate how to reproduce the traceback. |
Caused due to presence of Boolean arguments (False) while writing to
`game.xml`.
If `speak` is not set, it defaults to `False` in get_speak()
in `card.py`. The fix changes `False` to an empty String while writing
to `game.xml`.
Reproduce:
Click 'Edit Game' -> Make changes eg.Toggle between grouped and matched tiles
-> Click 'Play Game'
Traceback:
```
1594050507.412289 ERROR root: Error saving activity object to datastore
Traceback (most recent call last):
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 1076, in _escape_attrib
if "&" in text:
TypeError: argument of type 'bool' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/sugar3/activity/activity.py", line 1277, in _prepare_close
self.save()
File "/usr/lib/python3/dist-packages/sugar3/activity/activity.py", line 978, in save
self.write_file(file_path)
File "/usr/share/sugar/activities/Memorize.activity/activity.py", line 409, in write_file
self.game.model.write()
File "/usr/share/sugar/activities/Memorize.activity/model.py", line 357, in write
xml_file.write(tostring(root))
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 1133, in tostring
ElementTree(element).write(stream, encoding,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 772, in write
serialize(write, self._root, qnames, namespaces,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 930, in _serialize_xml
v = _escape_attrib(v)
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 1099, in _escape_attrib
_raise_serialization_error(text)
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 1053, in _raise_serialization_error
raise TypeError(
TypeError: cannot serialize False (type bool)
```
Fixes sugarlabs#29
|
I have added instructions to reproduce the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused due to presence of Boolean arguments (False) while writing to
game.xml.If
speakis not set, it defaults toFalsein set_speak()in
card.py. The fix changesFalseto an empty String while writingto
game.xml.Traceback:
Fixes #29