-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clear button and refractored code #19
Conversation
Signed-off-by: Ravjot Singh <[email protected]>
@quozl can you review this pr |
js/activity-works.js
Outdated
require("easel"); | ||
require("handlebars"); | ||
var shapes = require("activity/shapes"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these used here?
See #15 to make sure you've addressed the concerns listed there, reviewed, not tested. The code refactoring shouldn't be in the same commit as the clear button change, keep both separate as it's easier to review that way. |
yes i have addressed the concerns listed in #15.... mainly they discussed about position of the button and its icon visibility and its functioning about deleting only the drawing rather than whole canvas...... i have covered all of that |
@chimosky are there any more changes or suggestion or we should merge this PR |
Would be great to have better commit messages than "Minor Updates", see making commits. I'll test this once I can. |
@chimosky sure i will take care of commit msg next time. |
You can and should change commit messages now rather than wait for next time. |
…nsistency Signed-off-by: Ravjot Singh <[email protected]>
c48c985
to
f7ad58f
Compare
Done @quozl |
Tested. Reviewed. |
…cussed in PR sugarlabs#19 Signed-off-by: Ravjot Singh <[email protected]>
Added clear button that Clears the canvas and reset the drawing lines. Contribution towards #14
Clear_Button.mp4