#160445750 Implement API endpoints #12

sudhons · 2018-09-16T19:21:10Z

What does this PR do?
Implement endpoints required for fast-food-fast

Description of Task to be completed?
The following endpoints:

user should get all orders on route GET /api/v1/orders
user should get a single order with the order Id on route GET /api/v1/orders/<orderId>
user should post an order on route POST /api/v1/orders
Admin should update the status of an order on route UPDATE /api/v1/orders/<orderId>

What are the relevant pivotal tracker stories?
#160445750 #160508060 #160505911 #160477398 #160448545

.eslintrc.json

.gitignore

dogoyaro · 2018-09-17T15:16:44Z

API/src/app.js

+  return next(error);
+});
+
+// eslint-disable-next-line no-unused-vars


I don't think it's necessary to disable the rules on this line. You should be able to remove the arguments that are not used.

If I remove the next argument, the middleware will not work. I wanted to create a middleware that catches and resolves all errors.

You aren't using next though. I don't understand what you mean by it wouldn't work. I'll try this locally and get back to you.

It works without the next as I expected @sudhons. Please check and get back to me on this.

It works but when I pass an error object into next in any of the middlewares, I wanted this error handler alone to catch it. That syntax is the convention for error handlers. Without next, the default error handler will throw an error on the console and postman to the client.
Please check this: https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction#Handling_errors
and this: expressjs/express#2896

Why not return the response with the error within the middle-ware that the error is found?

dogoyaro · 2018-09-17T15:18:16Z

API/src/app.js

+
+const PORT = parseInt(process.env.PORT, 10) || 5000;
+
+if (require.main === module) {


I am curious about this check. Please explain.

The purpose is to check whether app.js is running as a script or it is being used as an imported file (which is the case when I run tests). When it runs as a script the check equals true and app.js runs its server. Since chai-http creates a different server for its tests, It wouldn't need the server on app.js. Without the check the server would be started when tests run.

I will remove the check and use another method to stop the server

@sudhons. You might not need to do that. I just wanted to understand what you'd done. If you find a better way to handle this though.
I am concerned that in the test environment, what you are checking for might not really matter.

API/src/controllers/ordersController.js

API/src/queries/orderQueries.js

dogoyaro · 2018-09-17T15:33:22Z

API/src/validators/validateOrders.js

@@ -0,0 +1,143 @@
+import { param, body, validationResult } from 'express-validator/check';
+import { sanitizeBody } from 'express-validator/filter';


I don't think you allowed to use a third-party validator (package) to do this. Please do whatever validation is needed with your own custom code.

Ok. I will remove that but I won't be able to sanitize user's inputs. Isn't that necessary?

You should be able to sanitize with your own custom code.

Procfile

dogoyaro · 2018-09-19T14:58:56Z

You can go on to merge this after squashing unnecessary commits.

[Chore #160445843] Set up eslint and airbnb sytle guide [Chore #160446860] set up babel transpiler [Chore #160446860] set up babel transpiler [Chore #160445853] set up mocha testing framework write queries to get all orders write test to get orders when there are no orders add controller to get all questions add controller to get all questions create queries for querying data write more tests write tests for queries add build folder to .gitignore [chore #160463621]set up travis and coveralls [bug #160464176] reconfigure travis [bug #160464176] reconfigure travis write test to confirm customer value exist [chore #160478899] install express validator [chore #160479790] write vaidation for post order route

write tests for get an order route write tests for get an order route write route to get a single order

write tests for update route write validator for update route

[Chore #160528618] configures API for heroku deployment

sudhons temporarily deployed to food-fast September 17, 2018 11:01 Inactive

dogoyaro requested changes Sep 17, 2018

View reviewed changes

sudhons force-pushed the feature-api-endpoints-160445750 branch from 739f096 to 440ef83 Compare September 19, 2018 13:25

sudhons added 5 commits September 19, 2018 19:29

[Feature #160477398] implement post an order route

31da6ff

write tests for get an order route write tests for get an order route write route to get a single order

[Feature #160505911] Implement the get an order route

cc7dd97

write tests for update route write validator for update route

[Feature #160508060] Implement update a status route

bb255a7

[Chore #160528618] configures API for heroku deployment

[Bug #160616909] Implement API feedback

bfa500e

sudhons force-pushed the feature-api-endpoints-160445750 branch from 440ef83 to bfa500e Compare September 19, 2018 18:35

sudhons merged commit 2e3ee10 into develop Sep 19, 2018

sudhons added a commit that referenced this pull request Sep 19, 2018

Merge pull request #12 from sudhons/feature-api-endpoints-160445750

4b2c75f

sudhons added a commit that referenced this pull request Sep 20, 2018

Merge pull request #12 from sudhons/feature-api-endpoints-160445750

80ae054

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#160445750 Implement API endpoints #12

#160445750 Implement API endpoints #12

sudhons commented Sep 16, 2018

dogoyaro Sep 17, 2018

sudhons Sep 17, 2018

dogoyaro Sep 17, 2018 •

edited

Loading

dogoyaro Sep 18, 2018

sudhons Sep 19, 2018 •

edited

Loading

dogoyaro Sep 19, 2018

dogoyaro Sep 17, 2018

sudhons Sep 17, 2018

dogoyaro Sep 17, 2018

dogoyaro Sep 17, 2018

sudhons Sep 17, 2018

dogoyaro Sep 17, 2018

dogoyaro commented Sep 19, 2018


		const PORT = parseInt(process.env.PORT, 10) \|\| 5000;

		if (require.main === module) {

		@@ -0,0 +1,143 @@
		import { param, body, validationResult } from 'express-validator/check';
		import { sanitizeBody } from 'express-validator/filter';

#160445750 Implement API endpoints #12

#160445750 Implement API endpoints #12

Conversation

sudhons commented Sep 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dogoyaro Sep 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhons Sep 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dogoyaro commented Sep 19, 2018

dogoyaro Sep 17, 2018 •

edited

Loading

sudhons Sep 19, 2018 •

edited

Loading