fix(sdk): .bytes() inconsistent behavior between groth16 and plonk
#1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratankaliani
changed the title
.bytes() inconsistent behavior between groth16 and plonk
|
SP1 Performance Test Results Branch: ratan/return-empty-bytes-groth16
|
yuwen01
approved these changes
Nov 20, 2024
ratankaliani
added a commit
that referenced
this pull request
Nov 20, 2024
ratankaliani
added a commit
that referenced
this pull request
Nov 27, 2024
ratankaliani
added a commit
that referenced
this pull request
Dec 10, 2024
ratankaliani
added a commit
that referenced
this pull request
Dec 11, 2024
ratankaliani
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inconsistent behavior in
bytesbetween mock PLONK and Groth16 proofs. This caused an issue inop-succinct.In the future, especially for PR's from external folks, we should have simple tests added in the relevant file to test behavior. This prevents issues such as this which lead to inconsistent API behavior.
Reversion introduced by #1685. Likely because base
devbranch was not up to date.Solution
Return an empty byte array from
.bytes()if it's a mock Groth16 proof.Add testing to confirm that
.bytes()returns the correct output in the future.Note: Did not test
SP1Proof::Compressedbecause constructing an emptyReduceProofwas difficult.PR Checklist