Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Latest Proven Transaction Metric #360

Closed
wants to merge 2 commits into from

Conversation

VolodymyrBg
Copy link

Description:
This PR adds a new metric to track the latest proven transaction in the L2 Output Oracle contract.

Changes:

  • Add LatestProvenTx field to ProposerMetrics struct
  • Add LatestProvenTx gauge metric to track the latest proven transaction block number
  • Update GetProposerMetrics to include the latest proven transaction data
  • Improve error messages for better debugging and error context

The new metric helps monitor the progress of transaction proving and provides better visibility into the system's state. This implementation resolves the TODO comment in the GetProposerMetrics function.

Testing:

  • Tested the metric collection functionality
  • Verified proper error handling
  • Confirmed metric is correctly populated from the L2 Output Oracle contract

Related TODO:
Resolves TODO: "Add a metric for the latest proven transaction"

VolodymyrBg added 2 commits February 1, 2025 11:59
Add a new metric to track the latest proven transaction block number in the L2 Output Oracle contract. This metric helps monitor the progress of transaction proving and provides better visibility into the system's state.

Changes:
- Add LatestProvenTx field to ProposerMetrics struct
- Add LatestProvenTx gauge metric to OPSuccinctMetrics
- Update GetProposerMetrics to track and return the latest proven transaction
- Update RecordProposerStatus to record the new metric
…ODO comment as the latest proven transaction metric is now implemented - Improve error messages for better debugging - Add proper error wrapping for better error context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants