[DRAFT] Fix typescript error avoid ID not matching when use @dbType #2658
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that IDs match correctly even when data types like BigInt, Int, or Float are used in GraphQL schemas. This prevents mismatches and ensures error handling for invalid ID comparisons.
The added `@ts-ignore` directive resolves a TypeScript error when calling `store.getByField` in the generated model template. This mostly to achieve a quick fix which should not be the final solution. The root problem is that Entity and BaseEntity does not allow other types than string for id, so the Compact and CompactEntity are an Omit from Entity with an override of the id field.
Suppresses a TypeScript warning in the `getByFields` method by adding a `@ts-ignore` comment.
12 tasks
marilene38
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that IDs match correctly even when data types like BigInt, Int, or Float are used in GraphQL schemas. This prevents mismatches and ensures error handling for invalid ID comparisons.
On Models template there are 2 types:
They both Omit the
idproperty, but one leave as string, which if we change the ID with@dbType()maybe get an error?For sure the
getByFieldshas a typescript error due to that because it expect the T to extend Entity which expect id be an string.Type of change
Please delete options that are not relevant.
Checklist