Fix lint issues, split CI tasks

.github/workflows/pr.yaml

@@ -33,8 +33,18 @@ jobs:
         with:
           deno-version: v1.x
 
-      - name: Check typescript
-        run: deno task check-ts
-
       - name: Lint
         run: deno lint
+
+  typescript:
+    name: typescript
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: denoland/setup-deno@v1
+        with:
+          deno-version: v1.x
+
+      - name: Check typescript
+        run: deno task check-ts

src/app.ts

@@ -43,7 +43,7 @@ export async function runApp(config: {
       ),
   );
 
-  const runnerHost = new RunnerHost(async () => {
+  const runnerHost = new RunnerHost(() => {
     const chatStorage = new MemoryChatStorage();
 
     chatStorage.append([{ role: "system", content: sandbox.systemPrompt }]);

src/bundle.ts

@@ -127,7 +127,7 @@ async function fsExists(path: string): Promise<boolean> {
   try {
     await Deno.lstat(path);
     return true;
-  } catch (e) {
+  } catch (_e) {
     return false;
   }
 }

src/chatStorage/memoryChatStoarge.ts

@@ -4,10 +4,12 @@ import { IChatStorage } from "./chatStorage.ts";
 export class MemoryChatStorage implements IChatStorage {
   private messages: Message[] = [];
 
+  // deno-lint-ignore require-await
   async getHistory(): Promise<Message[]> {
     return this.messages;
   }
 
+  // deno-lint-ignore require-await
   async append(messages: Message[]): Promise<void> {
     this.messages.push(...messages);
   }

src/context/context.ts

@@ -41,7 +41,7 @@ export class Context implements IContext {
     this.#vectorStorage = vectorStorage;
   }
 
-  async vectorSearch(tableName: string, vector: number[]): Promise<any[]> {
+  async vectorSearch(tableName: string, vector: number[]): Promise<unknown[]> {
     if (!this.#vectorStorage) {
       throw new Error(
         "Project did not provide vector storage. Unable to perform search",

src/embeddings/generator/generator.ts

@@ -31,14 +31,12 @@ export async function generate(
 
   for (const source of embeddingSources) {
     try {
-      const { checksum, meta, sections } = await source.load();
+      const { sections } = await source.load();
 
-      for (const { slug, heading, content } of sections) {
+      for (const { content } of sections) {
         // OpenAI recommends replacing newlines with spaces for best results (specific to embeddings)
         const input = content.replace(/\n/g, " ");
 
-        // console.log('CONTENT', content);
-
         lanceWriter.write(input);
       }
     } catch (e) {

src/embeddings/generator/mdSource.ts

@@ -1,7 +1,7 @@
 // This file is based on https://github.com/supabase-community/nextjs-openai-doc-search/blob/main/lib/generate-embeddings.ts
 
 // @ts-types="npm:@types/estree"
-import { ObjectExpression } from 'estree';
+import type { ObjectExpression } from 'estree';
 // @ts-types="npm:@types/mdast"
 import { Content, Root } from "mdast";
 import { fromMarkdown } from "mdast-util-from-markdown";

src/embeddings/lance/writer.ts

@@ -59,6 +59,7 @@ export class LanceWriter implements IEmbeddingWriter {
     await this.#table.add(data);
   }
 
+  // deno-lint-ignore require-await
   async close(): Promise<void> {
     return this.#table.close();
   }

src/fromSchema.ts

@@ -210,6 +210,7 @@ type TFromObject<T extends SObject> = TFromProperties<
   T["properties"],
   Exclude<T["required"], undefined>[number]
 > extends infer Properties extends Type.TProperties ? Type.TObject<Properties>
+  // deno-lint-ignore ban-types
   : Type.TObject<{}>;
 function FromObject<T extends SObject>(T: T): TFromObject<T> {
   const properties = globalThis.Object.getOwnPropertyNames(T.properties).reduce(

src/ipfs.ts

@@ -135,6 +135,8 @@ export class IPFSClient {
       throw new Error(await res.text());
     }
 
+    // This could use typebox for runtime validation
+    // deno-lint-ignore no-explicit-any 
     const mapResponse = (raw: any): AddResult => ({
       path: raw.Name,
       cid: raw.Hash,

src/ipfs_test.ts

@@ -1,6 +1,5 @@
 import { expect } from "@std/expect";
 import { IPFSClient } from "./ipfs.ts";
-import { Buffer } from "@std/io/buffer";
 
 const ipfs = new IPFSClient(
   Deno.env.get("IPFS_ENDPOINT") ??

src/loader.ts

@@ -91,7 +91,7 @@ export async function loadVectorStoragePath(
     if (uri.protocol) {
       return vectorStoragePath;
     }
-  } catch (e) {
+  } catch (_e) {
     // DO nothing
   }
 

src/project/project.ts

@@ -51,7 +51,7 @@ export const Project = Type.Object({
 export type IFunctionTool = Static<typeof FunctionToolType>;
 export type IVectorConfig = Static<typeof VectorConfig>;
 
-type IProjectEntry<Config extends TObject> = TUnion<[
+type IProjectEntry<Config extends TObject = TObject> = TUnion<[
   TObject<
     {
       configType: TSchema;
@@ -71,14 +71,16 @@ export type IProjectEntrypoint<T extends TObject = TObject> = Static<
   IProjectEntry<T>
 >;
 
-export function validateProject(project: any): void {
+export function validateProject(project: unknown): void {
   return Value.Assert(Project, project);
 }
 
-function validateProjectEntry(entry: any): void {
-  const projectType = ProjectEntrypointGen(entry?.configType);
+function validateProjectEntry(entry: unknown): entry is IProjectEntry {
+  // deno-lint-ignore no-explicit-any
+  const projectType = ProjectEntrypointGen((entry as any)?.configType);
 
   Value.Assert(projectType, entry);
+  return true;
 }
 
 const ProjectEntrypointGen = <T extends TObject>(t: T) =>
@@ -94,20 +96,22 @@ const ProjectEntrypointGen = <T extends TObject>(t: T) =>
   ]);
 
 export async function getProjectFromEntrypoint(
-  entrypoint: any,
+  entrypoint: unknown,
 ): Promise<IProject> {
   if (!entrypoint) {
     throw new Error("Project entry is invalid");
   }
   // Validate the entrypoint
-  validateProjectEntry(entrypoint);
+  if (validateProjectEntry(entrypoint)) {
+    const config = loadConfigFromEnv(entrypoint.configType);
 
-  const config = loadConfigFromEnv(entrypoint.configType);
+    // Check that the constructed project is valid
+    const project = await entrypoint.projectFactory(config);
 
-  // Check that the constructed project is valid
-  const project = await entrypoint.projectFactory(config);
+    validateProject(project);
 
-  validateProject(project);
-
-  return project;
+    return project;
+  } else {
+    throw new Error('Unable to validate project');
+  }
 }

src/runnerHost.ts

@@ -3,7 +3,7 @@ import { Runner } from "./runner.ts";
 export class RunnerHost {
   #runners: Record<string, Runner> = {};
 
-  constructor(private initRunner: () => Promise<Runner>) {}
+  constructor(private initRunner: () => Runner | Promise<Runner>) {}
 
   async getRunner(id: string): Promise<Runner> {
     this.#runners[id] ??= await this.initRunner();
@@ -12,6 +12,6 @@ export class RunnerHost {
   }
 
   async getAnonymousRunner(): Promise<Runner> {
-    return this.initRunner();
+    return await this.initRunner();
   }
 }

src/sandbox/mockSandbox.ts

@@ -1,3 +1,4 @@
+import { TSchema } from "@sinclair/typebox";
 import { IContext } from "../context/context.ts";
 import { ITool } from "../tool.ts";
 import { ISandbox } from "./sandbox.ts";
@@ -8,14 +9,15 @@ export class MockSandbox implements ISandbox {
     readonly systemPrompt: string,
     private tools: ITool[],
     readonly userMessage?: string,
-    readonly config?: any,
+    readonly config?: TSchema,
   ) {}
 
+  // deno-lint-ignore require-await
   async getTools() {
     return this.tools.map((t) => t.toTool());
   }
 
-  async runTool(toolName: string, args: any, ctx: IContext): Promise<any> {
+  runTool(toolName: string, args: unknown, ctx: IContext): Promise<string> {
     const tool = this.tools.find((t) => t.name === toolName);
 
     if (!tool) {

src/sandbox/sandbox.ts

@@ -28,7 +28,7 @@ export interface ISandbox {
 
   getTools(): Promise<Tool[]>;
 
-  runTool(toolName: string, args: any, ctx: IContext): Promise<any>;
+  runTool(toolName: string, args: unknown, ctx: IContext): Promise<string>;
 
   // TODO expand this interface with more untrusted data/functions. e.g RAG
 }

src/sandbox/unsafeSandbox.ts

@@ -6,7 +6,6 @@ import {
   validateProject,
 } from "../project/project.ts";
 import { ISandbox } from "./sandbox.ts";
-import { TSchema } from "@sinclair/typebox";
 import { IContext } from "../context/context.ts";
 
 /**
@@ -49,11 +48,12 @@ export class UnsafeSandbox implements ISandbox {
     return this.#project.vectorStorage;
   }
 
+  // deno-lint-ignore require-await
   async getTools(): Promise<Tool[]> {
     return this.#project.tools.map((t) => t.toTool());
   }
 
-  runTool(toolName: string, args: any, ctx: IContext): Promise<any> {
+  runTool(toolName: string, args: unknown, ctx: IContext): Promise<string> {
     const tool = this.#project.tools.find((t) => t.name === toolName);
 
     if (!tool) {

src/sandbox/webWorker/messages.ts

@@ -15,15 +15,15 @@ export const Init = new rpc.RequestType<
 export const GetConfig = new rpc.RequestType0<TSchema | undefined, void>(
   "get_config",
 );
-export const CallTool = new rpc.RequestType2<string, any, any, void>(
+export const CallTool = new rpc.RequestType2<string, unknown, string, void>(
   "call_tool",
 );
 
 // Sandbox -> Framework
 export const CtxVectorSearch = new rpc.RequestType2<
   string,
   number[],
-  any,
+  unknown[],
   void
 >("ctx_vector_search");
 export const CtxComputeQueryEmbedding = new rpc.RequestType<

src/sandbox/webWorker/webWorkerSandbox.ts

@@ -56,7 +56,7 @@ export class WebWorkerSandbox implements ISandbox {
 
     // Need to restore the config and make it compatible as it uses symbols internally
     const configType = rawConfigType
-      // @ts-ignore
+      // @ts-ignore functionally works but types are too complex
       ? FromSchema(JSON.parse(JSON.stringify(rawConfigType)))
       : undefined;
     const config = loadConfigFromEnv(configType);
@@ -91,6 +91,7 @@ export class WebWorkerSandbox implements ISandbox {
     return this.#config;
   }
 
+  // deno-lint-ignore require-await
   async getTools(): Promise<Tool[]> {
     return this.#tools;
   }
@@ -112,7 +113,7 @@ export class WebWorkerSandbox implements ISandbox {
     this.#hasSetupCxt = true;
   }
 
-  runTool(toolName: string, args: any, ctx: IContext): Promise<any> {
+  runTool(toolName: string, args: unknown, ctx: IContext): Promise<string> {
     // Connect up context so sandbox can call application
     this.#connection.onRequest(CtxVectorSearch, async (tableName, vector) => {
       const res = await ctx.vectorSearch(tableName, vector);

src/tool.ts

@@ -43,9 +43,9 @@ export abstract class FunctionTool<P extends Parameters = Parameters>
   abstract parameters: P;
   abstract description: string;
   abstract call(
-    args: Record<any, any>, /*RequiredParams<P> & OptionalParams<P>*/
+    args: unknown, /*RequiredParams<P> & OptionalParams<P>*/
     ctx: IContext,
-  ): Promise<any>;
+  ): Promise<string>;
 
   toTool(): Tool {
     return {

subquery-delegator/index.ts

@@ -38,6 +38,7 @@ If the question seems to be unrelated to the API, just return "I don't know" as
 
 export const entrypoint: IProjectEntrypoint<typeof ConfigType> = {
   configType: ConfigType,
+  // deno-lint-ignore require-await
   projectFactory: async (config: Config) => {
     const tools = [
       new TotalDelegation(config.GRAPHQL_ENDPOINT),
@@ -67,7 +68,7 @@ export const entrypoint: IProjectEntrypoint<typeof ConfigType> = {
 };
 
 // Some example messages to ask with this set of tools
-const messages = [
+const _messages = [
   // Delegation
   "My address is 0x108A496cDC32DA84e4D5905bb02ED695BC1024cd, use this for any further prompts. What is my delegation?",
   "Who am i delegating to?",

subquery-delegator/utils.ts

@@ -1,4 +1,4 @@
-export async function grahqlRequest<T = any>(
+export async function grahqlRequest<T = unknown>(
   endpoint: string,
   query: string,
   variables?: unknown,
@@ -19,7 +19,7 @@ export async function grahqlRequest<T = any>(
   if (res.errors) {
     console.log(`Request failed\n${query}`);
 
-    throw new Error(res.errors.map((e: any) => e.message).join("\n"));
+    throw new Error(res.errors.map((e: { message: string }) => e.message).join("\n"));
   }
 
   return res.data;