Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow update deployment and mark a deployment latest for a project #284

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Allow update deployment and mark a deployment latest for a project #284

merged 5 commits into from
Nov 9, 2023

Conversation

ianhe8x
Copy link
Contributor

@ianhe8x ianhe8x commented Nov 6, 2023

  • rename updateDeployment to addOrUpdateDeployment since that's what it is doing
  • allows updating existing deployment as long as
    • sender is the owner of the project
    • It actually writes the storage in the tx
  • allows marking an old deployment as latest
  • allows adding a new deployment without marking it latest
  • add bool updateLatest to addOrUpdateDeployment(..., bool updateLatest)
  • add bool updateLatest to event UpdateProjectDeployment(..., bool updateLatest)
  • add new error code PR007: deployment metadata not changed
  • update tests

@ianhe8x ianhe8x requested a review from mzxyz November 6, 2023 22:48
@mzxyz mzxyz mentioned this pull request Nov 7, 2023
Merged
@mzxyz
Improve update deployment (#285)
70d9c06 
* Improve `update deployment`

* Change the sequence of events in `addDeployment`

* Update ProjectRegistry Interface

* Update ABI

* Update revert error for `ProjectRegistry`

* Update tests

* Combine add and update deployment

* Update test

* Fix all the test
@ianhe8x ianhe8x merged commit d8e1561 into develop Nov 9, 2023
@ianhe8x ianhe8x deleted the update-deployment branch November 9, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzxyz mzxyz mzxyz left review comments

@nz-neooo nz-neooo nz-neooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianhe8x @mzxyz @nz-neooo