[JavaScript] Move JSON out of the JavaScript package #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thom1729
approved these changes
Dec 8, 2018
|
I think you're right about not needing the redirect, and I'm glad you checked the existing packages. In the unlikely event that this goes out in a dev build and breaks something, it would be extremely easy to put in a quick patch before the next build. |
As suggested in issue sublimehq#1771 this commit moves the JSON syntax into a dedicated package in order to be able to disable either JavaScript or JSON independently. This commit does not yet create the suggested compatibility redirection within the JavaScript package. The decision about it is left to the core devs right now 1. as it would cause a duplicated syntax file 2. a quick search within packagecontrol.io did not reveal any packages depending on the builtin JavaScript/JSON.sublime-syntax 3. the location of the sublime-syntax file should not be too important if it is imported via `scope:source.json` or its name `JSON.sublime-syntax` only. Conflicts would be caused only if it was imported via `Packages/JavaScript/JSON.sublime-syntax` which is easy to fix.
deathaxe
force-pushed
the
pr/json-move
branch
from
593dbbd to
d7bf5d6
Compare
wbond
added
the
on hold
|
I think we are going to take a swing at this as part of the next dev cycle. There will be some changes in the C++ codebase to ensure things don't go wonky for people with open files that reference the old syntax path, hence it will be put "on hold" for now and resolved at release time. |
|
relevant here: 9c44e60 |
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
Note from wbond: initial work on splitting JSON happened in 9c44e60, this ties up some loose ends. As suggested in issue sublimehq#1771 this commit moves the JSON syntax into a dedicated package in order to be able to disable either JavaScript or JSON independently. This commit does not yet create the suggested compatibility redirection within the JavaScript package. The decision about it is left to the core devs right now 1. as it would cause a duplicated syntax file 2. a quick search within packagecontrol.io did not reveal any packages depending on the builtin JavaScript/JSON.sublime-syntax 3. the location of the sublime-syntax file should not be too important if it is imported via `scope:source.json` or its name `JSON.sublime-syntax` only. Conflicts would be caused only if it was imported via `Packages/JavaScript/JSON.sublime-syntax` which is easy to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in issue #1771 this commit moves the JSON syntax into a dedicated package in order to be able to disable either JavaScript or JSON independently.
This commit does not yet create the suggested compatibility redirection within the JavaScript package.
The decision about it is left to the core devs right now
scope:source.jsonor its nameJSON.sublime-syntaxonly. Conflicts would be caused only if it was imported viaPackages/JavaScript/JSON.sublime-syntaxwhich is easy to fix.