Build and fix docker #133
Open
Build and fix docker #133
+106
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
force-pushed
the
fix-docker-buid
branch
from
21bf774 to
36eed6c
Compare
|
I didn't realize @RodrigoPrestes on #130 also did multi arch. |
|
from my tests, if your releases/tags are v#.#.# it'll tag docker images appropriately - https://github.com/halkeye/kobo-book-downloader/pkgs/container/kobo-book-downloader/336919635?tag=0.9.4 |
halkeye
force-pushed
the
fix-docker-buid
branch
from
34d0fdb to
36eed6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to build on release so version numbers match up
also build sha every commit
no hardcoded repo names so forks can build
build arm and amd images
upgrade poetry (to match what i had locally so i could fix lock file)