Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thermal expansion effects to FEA solver #2399

Merged
merged 5 commits into from
Dec 24, 2024
Merged

Add thermal expansion effects to FEA solver #2399

merged 5 commits into from
Dec 24, 2024

Conversation

pcarruscag
Copy link
Member

Proposed Changes

Fixed delta T based on freestream temperature and material reference temperature for now.
Thermal expansion coefficient can have one value per material (same as E, nu, and rho).

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 23, 2024
View reviewed changes
Common/include/geometry/elements/CElement.hpp
@@ -799,7 +826,7 @@
/*!
* \brief Shape function Jacobian (dNi) evaluated at point Xi,Eta.
*/
inline static void ShapeFunctionJacobian(su2double Xi, su2double Eta, su2double dNi[][2]) {
inline static void ShapeFunctionJacobian(const su2double& Xi, const su2double& Eta, su2double dNi[][2]) {

Check notice

Code scanning / CodeQL

No raw arrays in interfaces Note

Raw arrays should not be used in interfaces. A container class should be used instead.
Common/src/CConfig.cpp
"of entries (the number of materials).", CURRENT_FUNCTION);
if (nMaterialThermalExpansion == 0) {
nMaterialThermalExpansion = 1;
MaterialThermalExpansion = new su2double[1]();

Check warning

Code scanning / CodeQL

Resource not released in destructor Warning

Resource MaterialThermalExpansion is acquired by class CConfig but not released anywhere in this class.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COption deletes it its destructor

@pcarruscag pcarruscag mentioned this pull request Dec 24, 2024
Closed
4 tasks
@pcarruscag pcarruscag merged commit 2fb25a5 into develop Dec 24, 2024
34 of 35 checks passed
@pcarruscag pcarruscag deleted the thermo_elastic branch December 24, 2024 17:39
@Vaish-W Vaish-W mentioned this pull request Dec 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pcarruscag