Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup wall functions and add user controls #1360

Merged
merged 125 commits into from
Oct 20, 2021
Merged

Cleanup wall functions and add user controls #1360

Changes from 1 commit
Commits
Show all changes
125 commits
Select commit Hold shift + click to select a range
e5e5d19
fixed wall functions for SA and SST
bigfooted Feb 21, 2021
6be5670
cleaning up wall model implementation
bigfooted Feb 22, 2021
a62a0b8
cleaning up wall model implementation
bigfooted Feb 22, 2021
ecc7d3f
cleaning up wall model implementation
bigfooted Feb 22, 2021
f643214
Merge branch 'develop' into fix_wallfunctions
bigfooted Feb 22, 2021
3705941
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Feb 24, 2021
25fd773
merge develop back in
bigfooted Feb 24, 2021
cc1798f
cleanup based on code review
bigfooted Mar 2, 2021
e17af6d
Merge branch 'fix_wallfunctions' of https://github.com/su2code/SU2 in…
bigfooted Mar 2, 2021
76a14b2
Merge branch 'develop' into fix_wallfunctions
pcarruscag Mar 2, 2021
dbde0f7
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Mar 3, 2021
8e4c4b8
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Mar 3, 2021
f7972ae
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp
bigfooted Mar 3, 2021
b15e5f9
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Mar 3, 2021
f3551d8
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Mar 3, 2021
51da480
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Mar 3, 2021
f3f7139
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Mar 3, 2021
de8f6cd
Update SU2_CFD/src/solvers/CTurbSSTSolver.cpp
bigfooted Mar 3, 2021
ae7687e
Update SU2_CFD/include/solvers/CIncNSSolver.hpp
bigfooted Mar 3, 2021
7b61985
small update
bigfooted Mar 17, 2021
3e996bd
Merge branch 'fix_wallfunctions' of https://github.com/su2code/SU2 in…
bigfooted Mar 17, 2021
9437a11
Merge branch 'develop' into fix_wallfunctions
bigfooted Mar 17, 2021
658e7cb
Update SU2_CFD/include/solvers/CSolver.hpp
bigfooted Mar 17, 2021
ae47196
fix unused variables update
bigfooted Mar 17, 2021
06898d6
Merge branch 'fix_wallfunctions' of https://github.com/su2code/SU2 in…
bigfooted Mar 17, 2021
69e7fe1
fix unused variables update
bigfooted Mar 17, 2021
6d629c8
fix wall model constant config option
bigfooted Mar 18, 2021
0c0e3e6
fixed alignment and missing break statement
bigfooted Mar 20, 2021
fa88243
computing skinfriction when y+ < 5
bigfooted Mar 25, 2021
db32076
Merge remote-tracking branch 'upstream/develop' into develop
bigfooted Apr 1, 2021
4a4549b
merge with develop
bigfooted Apr 1, 2021
995f587
fix unused beta_1
bigfooted Apr 1, 2021
f713575
Merge remote-tracking branch 'upstream/develop' into develop
bigfooted May 18, 2021
e3b34a8
update with develop
bigfooted May 19, 2021
4b82974
fix OMP command
bigfooted May 19, 2021
423a89e
fix OMP command
bigfooted May 19, 2021
a6dc387
update to enum class
bigfooted May 19, 2021
b2fb98c
medi/ninja
bigfooted May 19, 2021
e32750f
remove vscode
bigfooted May 21, 2021
c33db7c
Update SU2_CFD/include/solvers/CTurbSSTSolver.hpp
pcarruscag May 29, 2021
722f3bb
Merge branch 'hybrid_parallel_ad3' into fix_wallfunctions
pcarruscag May 29, 2021
dabd9ee
Apply suggestions from code review
pcarruscag May 29, 2021
af96967
Merge branch 'fix_wallfunctions' of https://github.com/su2code/SU2 in…
pcarruscag May 29, 2021
a626425
small cleanup
pcarruscag May 29, 2021
ea38fd5
Merge remote-tracking branch 'upstream/develop' into fix_wallfunctions
pcarruscag May 29, 2021
a5a5835
a little more refactoring
pcarruscag May 29, 2021
fb3c0cc
apply fix from #1120 (do not consider tau wall for edges along wall),…
pcarruscag May 30, 2021
4172408
added config options
bigfooted May 30, 2021
44e5126
fixing wall temperature for wall function
Jun 9, 2021
557b950
Merge remote-tracking branch 'upstream/develop' into fix_wallfunctions
pcarruscag Jun 13, 2021
90723af
some fixes and better warnings
pcarruscag Jun 13, 2021
7ab705c
Merge branch 'develop' into fix_wallfunctions
pcarruscag Jun 15, 2021
9fd30a9
add testcase
bigfooted Jun 15, 2021
7d0d172
add testcase
bigfooted Jun 23, 2021
2b371f8
add config options for wall functions
bigfooted Jul 3, 2021
b874239
Merge branch 'su2code:fix_wallfunctions' into fix_wallfunctions
bigfooted Jul 3, 2021
3306eb9
fix y+ bug
bigfooted Jul 16, 2021
8c0a1f2
added testcase
bigfooted Aug 24, 2021
aa009e0
Merge branch 'develop' into fix_wallfunctions
bigfooted Aug 24, 2021
3a68a3e
remove deleted files CDiscAdFEAVariable
bigfooted Aug 24, 2021
075ef48
update wall temperature for aerodynamic heating
bigfooted Aug 24, 2021
caf9ab7
remove unused variables
bigfooted Aug 24, 2021
8066a23
Update Common/src/CConfig.cpp
bigfooted Aug 24, 2021
3ff82e5
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Aug 24, 2021
ec5ecec
Update Common/include/CConfig.hpp
bigfooted Aug 24, 2021
67b1a53
Update TestCases/wallfunctions/flatplate/turb_SA_flatplate.cfg
bigfooted Aug 24, 2021
1591c7c
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Aug 24, 2021
de13ceb
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Aug 24, 2021
f7d3a6b
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Aug 24, 2021
2d76265
reviewer changes
bigfooted Aug 24, 2021
9a67668
Merge branch 'fix_wallfunctions' of https://github.com/bigfooted/SU2 …
bigfooted Aug 24, 2021
d7197e0
update testcase
bigfooted Aug 24, 2021
9f39f7d
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Aug 25, 2021
ea14c02
Update SU2_CFD/include/solvers/CFVMFlowSolverBase.inl
bigfooted Aug 25, 2021
4226dbf
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Aug 25, 2021
b00e0ec
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Aug 25, 2021
5af6111
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Aug 25, 2021
b268a9d
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Aug 25, 2021
73f456c
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Aug 25, 2021
b2db011
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Aug 25, 2021
0940d87
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Aug 25, 2021
238c9e5
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Aug 25, 2021
474cee3
Update SU2_CFD/src/solvers/CTurbSASolver.cpp
bigfooted Aug 25, 2021
310585b
Update SU2_CFD/src/solvers/CTurbSSTSolver.cpp
bigfooted Aug 25, 2021
34a6eff
Update SU2_CFD/src/solvers/CTurbSSTSolver.cpp
bigfooted Aug 25, 2021
322f010
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Sep 6, 2021
10a69be
change some comments
bigfooted Sep 6, 2021
7c9b447
Update TestCases/wallfunctions/flatplate/turb_SA_flatplate.cfg
bigfooted Sep 6, 2021
3f4c2d0
Update TestCases/wallfunctions/flatplate/turb_SA_flatplate.cfg
bigfooted Sep 6, 2021
827fbbc
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Sep 6, 2021
ec87ed9
add additional testcases
bigfooted Sep 6, 2021
ffba868
Merge branch 'develop' into fix_wallfunctions
bigfooted Sep 6, 2021
dfd2939
added incomp. and comp. testcases
bigfooted Sep 20, 2021
545f139
cleanup of testcases config files
bigfooted Sep 20, 2021
00548d9
Update SU2_CFD/src/solvers/CIncNSSolver.cpp
bigfooted Sep 21, 2021
7f5a342
removed logfile
bigfooted Sep 21, 2021
0ca421f
Update SU2_CFD/src/solvers/CNSSolver.cpp
bigfooted Sep 21, 2021
1dd5c96
added nondimensionalization
bigfooted Sep 29, 2021
bbca88c
Merge branch 'fix_wallfunctions' of https://github.com/bigfooted/SU2 …
bigfooted Sep 29, 2021
11cb94e
Merge remote-tracking branch 'origin/develop' into fix_wallfunctions
TobiKattmann Sep 30, 2021
fc03901
Changes to Testcases cfg's. Fix convergence for inc cases.
TobiKattmann Sep 30, 2021
437d1fc
Add '_' in some var names to be consistent with cfg.
TobiKattmann Sep 30, 2021
651d669
Remove unused Wall_Functions Marker from Testcases repo.
TobiKattmann Sep 30, 2021
e48ba40
Remove empty added line.
TobiKattmann Sep 30, 2021
578822e
Rename TauWall functions to Tau_Wall to be consistent with var-name.
TobiKattmann Oct 1, 2021
3daef85
Update reg test vals. Adding more screen output fields.
TobiKattmann Oct 1, 2021
e2cdf26
Merge branch 'fix_wallfunctions' of https://github.com/bigfooted/SU2 …
TobiKattmann Oct 1, 2021
5a166b6
Merge remote-tracking branch 'origin/develop' into fix_wallfunctions
TobiKattmann Oct 7, 2021
dde0a9f
Remove unnecessary nondim. All values come from the solver itself.
TobiKattmann Oct 7, 2021
194692c
Const-ing vars in SetTau_Wall_WF func for NS and IncNS.
TobiKattmann Oct 7, 2021
9fe38b7
Rename Conductivity_Ref -> Thermal_Conductivity_Ref.
TobiKattmann Oct 7, 2021
0af828b
else not needed due to continue
pcarruscag Oct 7, 2021
d3b2fed
Minor changes. Comments and moved variable.
TobiKattmann Oct 7, 2021
b0bcd88
Merge branch 'fix_wallfunctions' of https://github.com/bigfooted/SU2 …
TobiKattmann Oct 7, 2021
7a7194c
Merge branch 'develop' into fix_wallfunctions
pcarruscag Oct 8, 2021
7d0a480
Merge remote-tracking branch 'origin/develop' into fix_wallfunctions
TobiKattmann Oct 13, 2021
17e52ea
Merge remote-tracking branch 'origin/develop' into fix_wallfunctions
TobiKattmann Oct 13, 2021
dd8d981
do not recompute y+ when wall functions are used
bigfooted Oct 16, 2021
b9e83e7
Update cfg files. Cleaning + formatting.
TobiKattmann Oct 16, 2021
e35cfeb
Merge branch 'develop' into fix_wallfunctions
TobiKattmann Oct 19, 2021
af850b9
Update TestCases/serial_regression.py
pcarruscag Oct 19, 2021
0111ebb
Merge remote-tracking branch 'origin/develop' into fix_wallfunctions
TobiKattmann Oct 19, 2021
9a3804a
Merge branch 'fix_wallfunctions' of https://github.com/bigfooted/SU2 …
TobiKattmann Oct 19, 2021
f9a5129
Merge remote-tracking branch 'origin/develop' into fix_wallfunctions
TobiKattmann Oct 19, 2021
d492fb4
Do some checks for the wall function impl in CConfig.
TobiKattmann Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TestCases/serial_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ def main():
turb_wallfunction_flatplate_sst.cfg_dir = "wallfunctions/flatplate/compressible_SST"
turb_wallfunction_flatplate_sst.cfg_file = "turb_SST_flatplate.cfg"
turb_wallfunction_flatplate_sst.test_iter = 10
turb_wallfunction_flatplate_sst.test_vals = [-4.230000, -1.930543, -1.998684, 1.250334, -1.635534, 1.462491, 10, -2.151894, 0.072872, 0.002514] #last 10 columns
turb_wallfunction_flatplate_sst.test_vals = [-4.229955, -1.930560, -1.998477, 1.250383, -1.635663, 1.462396, 10.000000, -2.151959, 0.072873, 0.002514] #last 10 columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this "final" addition and all the help on this (where of course @bigfooted did the heavy lifting ;) )

Now this is good to go from my perspective, I have no further comments. Maybe we can merge this in todays dev meeting :)

Things tbd in the future are

  • consolidate compr and inc implementation into some unified entitiy
  • Distribute Testcases over parallel, hybrid regression test
  • explanation on the website, tutorial

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright merging this in now ✈️

turb_wallfunction_flatplate_sst.su2_exec = "SU2_CFD"
turb_wallfunction_flatplate_sst.timeout = 1600
turb_wallfunction_flatplate_sst.tol = 0.00001
Expand Down