Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch from yarn@3 to npm@10 #1021

Merged
merged 9 commits into from
Nov 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node: [16, 18]
node: [18, 20]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
Expand All @@ -29,6 +29,8 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: yarn install
- run: yarn run lint
- run: yarn run test
- run: corepack enable npm
- run: npm --version
- run: npm install
- run: npm run lint
- run: npm run test
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ dist
.next
pages/*.js
src/*.js
public/yarn.js
test/hardlink/link
dev.sh
.now
.vercel
.yarn/cache
.yarn/install-state.gz
786 changes: 0 additions & 786 deletions .yarn/releases/yarn-3.2.1.cjs

This file was deleted.

2 changes: 0 additions & 2 deletions .yarnrc.yml

This file was deleted.

6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Now the web app should be available at http://localhost:3000
Make sure the tests are passing.

```
yarn run test
npm run test
```

## Deploying the code
Expand All @@ -75,6 +75,6 @@ Then you can simply run `vercel` to deploy.
Wow you're doing great! Before you submit a Pull Request, please create an issue so that we can discuss the problem you are solving. When we're all on the same page, make sure you test the code and prettify the code. And please add additional tests if possible.

```sh
yarn run test
yarn run prettier
npm run test
npm run prettier
```
Loading