Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/minorimprovements #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

verybadsoldier
Copy link
Contributor

I would like to propose this PR which includes some improvements (in my opinion):

  • when removing directories the retry behavior was changed from try-count based to timeout based. The timeout value can be configured by a property (as a Timespan object). I had problems with the old "timeout" when testing on a machine which was under heavy load.
  • some errors that were logged and swallowed before now do throw. In my opinion those errors should be result in failed tests
  • changed the name of the MySQL executalbe from mysqld.exe to mysqld_test.exe so it is easy to distinguish from a real mysql daemon

* added waiting for killed process
* throw on delete error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant