Add Cap and Capf assertions
#1333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moeen
force-pushed
the
feature/add-cap
branch
from
f756b9b to
0ab3ce1
Compare
moeen
force-pushed
the
feature/add-cap
branch
3 times, most recently
from
18962d9 to
38dcdce
Compare
moeen
force-pushed
the
feature/add-cap
branch
from
38dcdce to
6a95945
Compare
|
That would be just a convenience for a niche use case. I don't think that it is worth extending the API surface at this point. |
dolmen
added
enhancement
revisit
pkg-assert
dolmen
requested changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
CapandCapfassertions to assert capacity ofArray,SliceandChanneltypes.Motivation
There is no assertions for capacities in Go in this library. It is specially useful to assert capacity of buffered channels.
Currently you should use
assert.Equaland use thecapfunction.Related issues
#1332