Support data source for service account, pulsar instance and pulsar cluster #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support-data-source
zerbitx
reviewed
Jan 3, 2024
cloud/pulsar_cluster_config.go
Outdated
Comment on lines
47
to
57
| func flattenKafkaConfig(flag string) map[string]interface{} { | ||
| att := make(map[string]interface{}) | ||
| att["enabled"] = flag | ||
| return att | ||
| } | ||
|
|
||
| func flattenMqttConfig(flag string) map[string]interface{} { | ||
| att := make(map[string]interface{}) | ||
| att["enabled"] = flag | ||
| return att | ||
| } |
There was a problem hiding this comment.
Not important, just a style choice.
Suggested change
| func flattenKafkaConfig(flag string) map[string]interface{} { | |
| att := make(map[string]interface{}) | |
| att["enabled"] = flag | |
| return att | |
| } | |
| func flattenMqttConfig(flag string) map[string]interface{} { | |
| att := make(map[string]interface{}) | |
| att["enabled"] = flag | |
| return att | |
| } | |
| func flattenKafkaConfig(flag string) map[string]interface{} { | |
| return map[string]interface{}{ | |
| "enabled": flag, | |
| } | |
| } | |
| func flattenMqttConfig(flag string) map[string]interface{} { | |
| return map[string]interface{}{ | |
| "enabled": flag, | |
| } | |
| } |
zerbitx
reviewed
Jan 3, 2024
|
@zerbitx Can you take a look at this pr? |
ciiiii
reviewed
Jan 5, 2024
ciiiii
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.