feat: add release channel support for pulsar cluster #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lili <[email protected]>
tuteng
reviewed
Apr 28, 2024
Signed-off-by: lili <[email protected]>
tuteng
reviewed
Apr 28, 2024
| "release_channel": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "rapid", |
There was a problem hiding this comment.
Is the rapid channel used by default?
There was a problem hiding this comment.
yes, on UI also uses the rapid as default
There was a problem hiding this comment.
yes, keep consistent with console UI
tuteng
reviewed
Apr 28, 2024
cloud/resource_pulsar_cluster.go
Outdated
| Optional: true, | ||
| Default: "rapid", | ||
| Description: descriptions["release_channel"], | ||
| ValidateFunc: validateNotBlank, |
There was a problem hiding this comment.
Maybe you can add a function validateReleaseChannel to verify if it is lts, rapid or null.
Signed-off-by: lili <[email protected]>
Signed-off-by: lili <[email protected]>
done, thanks. |
Signed-off-by: lili <[email protected]>
Signed-off-by: lili <[email protected]>
Signed-off-by: lili <[email protected]>
Signed-off-by: lili <[email protected]>
tuteng
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #43