Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have name be generated for uniqueness #42

Merged
merged 11 commits into from
Apr 11, 2024
Merged

Have name be generated for uniqueness #42

merged 11 commits into from
Apr 11, 2024

Conversation

mitch-hamm
Copy link
Contributor

closes: #40

cloud/validate_helpers.go Outdated Show resolved Hide resolved
@@ -91,7 +91,7 @@ func init() {
"gcp": "GCP configuration for the connection",
"azure": "Azure configuration for the connection",
"cloud_connection_name": "Name of the cloud connection",
"cloud_environment_name": "Name of the cloud environment",
"cloud_environment_type": "Type of the cloud environment, either: test, staging or production",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"cloud_environment_type": "Type of the cloud environment, either: test, staging or production",
"cloud_environment_type": "Type of the cloud environment, either: dev, test, staging, production, acc, qa or poc",

cloud/validate_helpers.go Outdated Show resolved Hide resolved
cloud/validate_helpers.go Outdated Show resolved Hide resolved
@mitch-hamm mitch-hamm requested a review from maxsxu April 10, 2024 18:12
cloud/validate_helpers.go Outdated Show resolved Hide resolved
cloud/provider.go Outdated Show resolved Hide resolved
maxsxu
maxsxu previously approved these changes Apr 11, 2024
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urfreespace
Copy link
Member

and @mitch-hamm could you show your test result? maybe a testing screenshot provided is better

@mitch-hamm
Copy link
Contributor Author

and @mitch-hamm could you show your test result? maybe a testing screenshot provided is better

I'll add a code block as the screen shot has internal information

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # streamnative_cloud_connection.test-cloud-connection will be created
  + resource "streamnative_cloud_connection" "test-cloud-connection" {
      + id           = (known after apply)
      + name         = "infra-api-test-gcp-connection"
      + organization = "xxx"
      + type         = "gcp"

      + gcp {
          + project_id = "xxx"
        }
    }

  # streamnative_cloud_environment.test-cloud-environment will be created
  + resource "streamnative_cloud_environment" "test-cloud-environment" {
      + cloud_connection_name = "infra-api-test-gcp-connection"
      + id                    = (known after apply)
      + organization          = "xxx"
      + region                = "us-west1"
      + type                  = "dev"

      + network {
          + cidr = "10.0.0.0/16"
        }
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

streamnative_cloud_connection.test-cloud-connection: Creating...
streamnative_cloud_environment.test-cloud-environment: Creating...
streamnative_cloud_connection.test-cloud-connection: Creation complete after 1s [id=xxx/infra-api-test-gcp-connection]

@mitch-hamm mitch-hamm merged commit ab93415 into main Apr 11, 2024
1 check passed
@mitch-hamm mitch-hamm deleted the mh/40 branch April 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generate unified metadata name for CloudEnvironment
3 participants