Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test on github action workflow #2

Merged
merged 30 commits into from
Dec 27, 2023
Merged

Enable test on github action workflow #2

merged 30 commits into from
Dec 27, 2023

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Dec 25, 2023

No description provided.

@tuteng tuteng changed the title Enable workflow test Enable test on github action workflow Dec 25, 2023
@tuteng tuteng requested review from a team December 27, 2023 01:41
ciiiii
ciiiii reviewed Dec 27, 2023
View reviewed changes
cloud/provider.go Outdated Show resolved Hide resolved
ciiiii
ciiiii approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@ciiiii ciiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuteng tuteng merged commit 9524d6d into main Dec 27, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/enable-workflow-test branch December 27, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciiiii ciiiii ciiiii approved these changes

@fantapsody fantapsody Awaiting requested review from fantapsody

@maxsxu maxsxu Awaiting requested review from maxsxu

@urfreespace urfreespace Awaiting requested review from urfreespace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuteng @ciiiii