Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GoReleaser lint issue #127

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix: GoReleaser lint issue #127

merged 3 commits into from
Oct 3, 2024

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Oct 3, 2024

Motivation

fix failed action: https://github.com/streamnative/terraform-provider-pulsar/actions/runs/11153599950

Modifications

  • fix goreleaser yaml
  • add CI to check goreleaser

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested a review from a team as a code owner October 3, 2024 02:13
Copy link

github-actions bot commented Oct 3, 2024

@ciiiii:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Oct 3, 2024
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

@ciiiii:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Oct 3, 2024
@ciiiii ciiiii merged commit bef7fdf into master Oct 3, 2024
4 checks passed
@ciiiii ciiiii deleted the yscai/fix-goreleaser branch October 3, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants