Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subscription dispatch rate to namespace resource #118

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

efcasado
Copy link
Contributor

@efcasado efcasado commented Mar 11, 2024

Motivation

At the time of this writing, dispatch_rate can only be used for configuring the dispatch rate for all the topics under a given namespace. This pull-request adds support for configuring the dispatch rate for all the subscriptions under a given namespace, which can come in handy in cases where more granular control is needed to prevent one subscription putting excessive load on a broker.

Modifications

  • Added subscription_dispatch_rate to the pulsar_namespace resource
  • Updated the documentation to reflect the difference between dispatch_rate and subscription_dispatch_rate

Verifying this change

  • Make sure that the change passes the CI checks.

  • *This change is already covered by existing tests, such as (please describe tests).

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@efcasado efcasado requested a review from a team as a code owner March 11, 2024 17:24
Copy link

@efcasado:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Mar 11, 2024
Copy link

@efcasado:Thanks for providing doc info!

@github-actions github-actions bot added doc This pr contains a document and removed doc-info-missing This pr needs to mark a document option in description labels Mar 11, 2024
@efcasado efcasado force-pushed the subscription-dispatch-rate branch 3 times, most recently from a595302 to b7f1c7e Compare March 12, 2024 13:56
@efcasado efcasado force-pushed the subscription-dispatch-rate branch from b7f1c7e to 6371d9e Compare March 12, 2024 13:58
@efcasado efcasado force-pushed the subscription-dispatch-rate branch from 8848cf1 to 001157e Compare March 28, 2024 15:58
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efcasado Thanks for your contribution!

@maxsxu maxsxu requested a review from a team April 9, 2024 12:07
Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxsxu maxsxu merged commit 969d5ef into streamnative:master Apr 20, 2024
3 checks passed
@efcasado efcasado deleted the subscription-dispatch-rate branch April 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants