-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add subscription dispatch rate to namespace resource #118
feat: add subscription dispatch rate to namespace resource #118
Conversation
@efcasado:Thanks for your contribution. For this PR, do we need to update docs? |
@efcasado:Thanks for providing doc info! |
a595302
to
b7f1c7e
Compare
b7f1c7e
to
6371d9e
Compare
8848cf1
to
001157e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efcasado Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
At the time of this writing,
dispatch_rate
can only be used for configuring the dispatch rate for all the topics under a given namespace. This pull-request adds support for configuring the dispatch rate for all the subscriptions under a given namespace, which can come in handy in cases where more granular control is needed to prevent one subscription putting excessive load on a broker.Modifications
subscription_dispatch_rate
to thepulsar_namespace
resourcedispatch_rate
andsubscription_dispatch_rate
Verifying this change
Make sure that the change passes the CI checks.
*This change is already covered by existing tests, such as (please describe tests).
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)