-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add of offload threshold property in namespace configuration #109
feat: add of offload threshold property in namespace configuration #109
Conversation
@shodo:Thanks for your contribution. For this PR, do we need to update docs? |
@shodo:Thanks for providing doc info! |
7e123b2
to
4b1db24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shodo Thanks for contribution!
Could you update the docs by run go generate
, since this PR introduced new param?
done! |
Hi guys! I see this PR have been opened 5 months ago and I need the same functionality as @shodo implemented, is there any blocker to include the change in the next release? How can I help? |
… in the namespace_config
bb6c183
to
4adc3f4
Compare
I've rebased my forked repo on the last changes and re-generated the doc to be 100% sure everything is aligned. Let me know if there is something I can do to speed up the merge |
@shodo @giacomo-porro The terraform-provider-pulsar v0.3.1 has released and this PR included. Thanks for your contributions again! |
Motivation
In the company I work with, we needed to enable "infinite" retention for certain topics. This paradigm requires offloading part of the topic to S3 when a certain size threshold is reached.
I know that Pulsar offers this configuration on a namespace level, but the Terraform plugin does not expose this configuration, so I'm creating this PR to add an
offload_threshold_size_in_mb
property to thenamespace_config
Modifications
offload_threshold_size_in_mb
property in the namespace_configNamespaceConfig
typeVerifying this change
This change is already covered by existing tests, such as resource_pulsar_namespace_test.go, I've just added the new
offload_threshold_size_in_mb
in the testPulsarNamespace fixture.Documentation
doc