Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support user_config when creating function #107

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

nlu90
Copy link
Contributor

@nlu90 nlu90 commented Nov 6, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #106

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nlu90 nlu90 self-assigned this Nov 6, 2023
@nlu90 nlu90 requested a review from a team as a code owner November 6, 2023 23:40
Copy link

github-actions bot commented Nov 6, 2023

@nlu90:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Nov 6, 2023
@labuladong labuladong merged commit fc080a8 into master Dec 11, 2023
4 checks passed
@labuladong labuladong deleted the neng/support-func-user-config branch December 11, 2023 01:36
@labuladong
Copy link
Member

Merge this because the k8s-change-stream application needs this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function support provide user_config
3 participants