feat: configure default grpc server keepalive enforcement policy #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
lhotari
reviewed
Jan 14, 2025
| @@ -58,7 +58,7 @@ jobs: | |||
| uses: docker/build-push-action@v3 | |||
| with: | |||
| context: . | |||
| platforms: linux/x86_64,linux/arm64 | |||
There was a problem hiding this comment.
Is it intentional to drop support for linux/arm64?
There was a problem hiding this comment.
GitHub has support for arm64 runners if the slowness of the emulated mode is the reason to drop linux/arm64 support. https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/
There was a problem hiding this comment.
oh, I just build testing image for internal testing. sorry.
codelipenghui
approved these changes
Jan 15, 2025
RobertIndie
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
configure default grpc server keepalive enforcement policy
Modification