fix charts for datadog #1202
Merged
fix charts for datadog #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
labuladong
force-pushed
the
donglai/fix/datadog
branch
from
1cf5e06 to
7ebeef0
Compare
labuladong
commented
Jan 24, 2025
Comment on lines
51
to
55
| ad.datadoghq.com/vault.checks: | | ||
| { | ||
| "openmetrics": { | ||
| "init_config": [{}], | ||
| "vault": { | ||
| "init_config": {}, | ||
| "instances": [ |
labuladong
commented
Jan 24, 2025
Comment on lines
15
to
18
| {{/*Define broker autorecovery name*/}} | ||
| {{- define "pulsar.autorecovery.podName" -}} | ||
| {{- print "autorecovery" -}} | ||
| {{- define "pulsar.autorecovery.containerName" -}} | ||
| {{- print "bookie-recovery" -}} | ||
| {{- end -}} |
ericsyh
approved these changes
Jan 30, 2025
ericsyh
pushed a commit
that referenced
this pull request
Jan 30, 2025
Fixes streamnative/eng-support-tickets#2331 (cherry picked from commit 4351df9)
ericsyh
pushed a commit
that referenced
this pull request
Jan 30, 2025
Fixes streamnative/eng-support-tickets#2331 (cherry picked from commit 4351df9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/streamnative/eng-support-tickets/issues/2331?reload=1?reload=1