Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RabbitMQ amqp-client dependency for test #1064

Merged

Conversation

gaoran10
Copy link
Collaborator

Motivation

Currently, the "com.rabbitmq:amqp-client" dependency is from bookkeeper-stats, we should dependent it directly.

+- io.streamnative:managed-ledger:jar:3.0.0.1-SNAPSHOT:provided
|  +- org.apache.bookkeeper.stats:prometheus-metrics-provider:jar:4.15.3:provided
|  |  +- org.apache.bookkeeper.stats:bookkeeper-stats-api:jar:4.15.3:provided
|  |  \- io.prometheus:simpleclient_servlet:jar:0.16.0:provided
|  |     +- io.prometheus:simpleclient_common:jar:0.16.0:provided
|  |     \- io.prometheus:simpleclient_servlet_common:jar:0.16.0:provided
|  +- org.apache.bookkeeper.stats:codahale-metrics-provider:jar:4.15.3:provided
|  |  +- io.dropwizard.metrics:metrics-jmx:jar:4.1.12.1:provided
|  |  +- io.dropwizard.metrics:metrics-jvm:jar:4.1.12.1:provided
|  |  \- io.dropwizard.metrics:metrics-graphite:jar:4.1.12.1:provided
|  |     \- com.rabbitmq:amqp-client:jar:5.8.0:provided

Modifications

Add the "com.rabbitmq:amqp-client" dependency with test scope.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@codelipenghui codelipenghui merged commit 567ab94 into streamnative:master Nov 30, 2023
7 checks passed
@codelipenghui codelipenghui deleted the fix-test-dependency-amqp-client branch November 30, 2023 05:18
gaoran10 added a commit that referenced this pull request Nov 30, 2023
gaoran10 added a commit that referenced this pull request Nov 30, 2023
gaoran10 added a commit that referenced this pull request Nov 30, 2023
gaoran10 added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants